* [PATCH -next] scsi: lpfc: Make lpfc_defer_acc_rsp static
@ 2020-01-07 1:49 YueHaibing
2020-01-07 18:22 ` James Smart
2020-01-10 6:26 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2020-01-07 1:49 UTC (permalink / raw)
To: james.smart, dick.kennedy, jejb, martin.petersen
Cc: linux-scsi, linux-kernel, YueHaibing
Fix sparse warning:
drivers/scsi/lpfc/lpfc_nportdisc.c:344:1: warning:
symbol 'lpfc_defer_acc_rsp' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/scsi/lpfc/lpfc_nportdisc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c
index 1c46e3a..a024e5a 100644
--- a/drivers/scsi/lpfc/lpfc_nportdisc.c
+++ b/drivers/scsi/lpfc/lpfc_nportdisc.c
@@ -340,7 +340,7 @@ lpfc_defer_pt2pt_acc(struct lpfc_hba *phba, LPFC_MBOXQ_t *link_mbox)
* This routine is only called if we are SLI4, acting in target
* mode and the remote NPort issues the PLOGI after link up.
**/
-void
+static void
lpfc_defer_acc_rsp(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
{
struct lpfc_vport *vport = pmb->vport;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] scsi: lpfc: Make lpfc_defer_acc_rsp static
2020-01-07 1:49 [PATCH -next] scsi: lpfc: Make lpfc_defer_acc_rsp static YueHaibing
@ 2020-01-07 18:22 ` James Smart
2020-01-10 6:26 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: James Smart @ 2020-01-07 18:22 UTC (permalink / raw)
To: YueHaibing, dick.kennedy, jejb, martin.petersen; +Cc: linux-scsi, linux-kernel
On 1/6/2020 5:49 PM, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/scsi/lpfc/lpfc_nportdisc.c:344:1: warning:
> symbol 'lpfc_defer_acc_rsp' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/scsi/lpfc/lpfc_nportdisc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c
> index 1c46e3a..a024e5a 100644
> --- a/drivers/scsi/lpfc/lpfc_nportdisc.c
> +++ b/drivers/scsi/lpfc/lpfc_nportdisc.c
> @@ -340,7 +340,7 @@ lpfc_defer_pt2pt_acc(struct lpfc_hba *phba, LPFC_MBOXQ_t *link_mbox)
> * This routine is only called if we are SLI4, acting in target
> * mode and the remote NPort issues the PLOGI after link up.
> **/
> -void
> +static void
> lpfc_defer_acc_rsp(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
> {
> struct lpfc_vport *vport = pmb->vport;
Yep. Looks good. Thank You
Reviewed-by: James Smart <james.smart@broadcom.com>
-- james
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] scsi: lpfc: Make lpfc_defer_acc_rsp static
2020-01-07 1:49 [PATCH -next] scsi: lpfc: Make lpfc_defer_acc_rsp static YueHaibing
2020-01-07 18:22 ` James Smart
@ 2020-01-10 6:26 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-01-10 6:26 UTC (permalink / raw)
To: YueHaibing
Cc: james.smart, dick.kennedy, jejb, martin.petersen, linux-scsi,
linux-kernel
YueHaibing,
> Fix sparse warning:
>
> drivers/scsi/lpfc/lpfc_nportdisc.c:344:1: warning:
> symbol 'lpfc_defer_acc_rsp' was not declared. Should it be static?
Applied to 5.6/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-10 6:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-07 1:49 [PATCH -next] scsi: lpfc: Make lpfc_defer_acc_rsp static YueHaibing
2020-01-07 18:22 ` James Smart
2020-01-10 6:26 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox