* [PATCH -next] scsi: ufshcd: Remove dev_err() on platform_get_irq() failure
@ 2019-11-01 14:00 YueHaibing
2019-11-13 2:31 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-11-01 14:00 UTC (permalink / raw)
To: alim.akhtar, avri.altman, pedrom.sousa, jejb, martin.petersen,
stanley.chu, yuehaibing, arnd
Cc: linux-scsi, linux-kernel
platform_get_irq() will call dev_err() itself on failure,
so there is no need for the driver to also do this.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/scsi/ufs/ufshcd-pltfrm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
index 8d40dc9..76f9be7 100644
--- a/drivers/scsi/ufs/ufshcd-pltfrm.c
+++ b/drivers/scsi/ufs/ufshcd-pltfrm.c
@@ -402,7 +402,6 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(dev, "IRQ resource not available\n");
err = -ENODEV;
goto out;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] scsi: ufshcd: Remove dev_err() on platform_get_irq() failure
2019-11-01 14:00 [PATCH -next] scsi: ufshcd: Remove dev_err() on platform_get_irq() failure YueHaibing
@ 2019-11-13 2:31 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2019-11-13 2:31 UTC (permalink / raw)
To: YueHaibing
Cc: alim.akhtar, avri.altman, pedrom.sousa, jejb, martin.petersen,
stanley.chu, arnd, linux-scsi, linux-kernel
YueHaibing,
> platform_get_irq() will call dev_err() itself on failure, so there is
> no need for the driver to also do this. This is detected by
> coccinelle.
Applied to 5.5/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-13 2:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-01 14:00 [PATCH -next] scsi: ufshcd: Remove dev_err() on platform_get_irq() failure YueHaibing
2019-11-13 2:31 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox