From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: James Bottomley <jejb@linux.ibm.com>
Cc: Waiman Long <longman@redhat.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: ses: Fix out-of-bounds memory access in ses_enclosure_data_process()
Date: Mon, 20 May 2019 12:05:38 -0400 [thread overview]
Message-ID: <yq1zhnh8625.fsf@oracle.com> (raw)
In-Reply-To: <1558367212.3742.10.camel@linux.ibm.com> (James Bottomley's message of "Mon, 20 May 2019 08:46:52 -0700")
James,
> Please. What I'm interested in is whether this is simply a bug in the
> array firmware, in which case the fix is sufficient, or whether
> there's some problem with the parser, like mismatched expectations
> over added trailing nulls or something.
Our support folks have been looking at this for a while. We have seen
problems with devices from several vendors. To the extent that I gave up
the idea of blacklisting all of them.
I am collecting "bad" SES pages from these devices. I have added support
for RECEIVE DIAGNOSTICS to scsi_debug and added a bunch of deliberately
broken SES pages so we could debug this.
It appears to be very common for devices to return inconsistent or
invalid data. So pretty much all of the ses.c parsing needs to have
sanity checking heuristics added to prevent KASAN hiccups.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-05-20 16:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 18:05 [PATCH] scsi: ses: Fix out-of-bounds memory access in ses_enclosure_data_process() Waiman Long
2019-05-20 14:41 ` Waiman Long
2019-05-20 14:52 ` James Bottomley
2019-05-20 15:24 ` Waiman Long
2019-05-20 15:46 ` James Bottomley
2019-05-20 15:56 ` Waiman Long
2019-05-21 17:23 ` Waiman Long
2019-05-20 16:05 ` Martin K. Petersen [this message]
2019-05-20 21:53 ` Douglas Gilbert
2019-05-21 12:02 ` Martin K. Petersen
2019-07-18 18:18 ` Waiman Long
2019-07-18 18:26 ` Martin K. Petersen
2019-07-18 18:29 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1zhnh8625.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=longman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox