Re: [PATCH 0/7] SCSI: cleanup debugfs usage

John Garry
2019-01-23T09:24:08Z

On 22/01/2019 15:08, Greg Kroah-Hartman wrote:
> When calling debugfs code, there is no need to ever check the return
> value of the call, as no logic should ever change if a call works
> properly or not. Fix up a bunch of x86-specific code to not care about
> the results of debugfs.
>
> Greg Kroah-Hartman (7):
> scsi: bfa: no need to check return value of debugfs_create functions
> scsi: csiostor: no need to check return value of debugfs_create
> functions
> scsi: fnic: no need to check return value of debugfs_create functions
> scsi: snic: no need to check return value of debugfs_create functions
> scsi: lpfc: no need to check return value of debugfs_create functions
> scsi: qlogic: no need to check return value of debugfs_create
> functions
> scsi: qla2xxx: no need to check return value of debugfs_create
> functions
>

JFYI, Martin has some more debugfs usage queued for 5.1 here:
https://kernel.googlesource.com/pub/scm/linux/kernel/git/mkp/scsi/+log/5.1/scsi-queue/drivers/scsi/hisi_sas

I'll send a patch to tidy-up, as above. It would not be x86 specific,
but I am not sure what above is.

Thanks,
John

> drivers/scsi/bfa/bfad_debugfs.c | 17 ---
> drivers/scsi/csiostor/csio_init.c | 6 +-
> drivers/scsi/fnic/fnic_debugfs.c | 88 +---------------
> drivers/scsi/fnic/fnic_main.c | 7 +-
> drivers/scsi/fnic/fnic_stats.h | 2 +-
> drivers/scsi/fnic/fnic_trace.c | 17 +--
> drivers/scsi/fnic/fnic_trace.h | 4 +-
> drivers/scsi/lpfc/lpfc_debugfs.c | 170 ------------------------------
> drivers/scsi/qedf/qedf_debugfs.c | 18 +---
> drivers/scsi/qedi/qedi_debugfs.c | 17 +--
> drivers/scsi/qla2xxx/qla_dfs.c | 43 +-------
> drivers/scsi/snic/snic_debugfs.c | 133 +++++------------------
> drivers/scsi/snic/snic_main.c | 14 +--
> drivers/scsi/snic/snic_stats.h | 2 +-
> drivers/scsi/snic/snic_trc.c | 12 +--
> drivers/scsi/snic/snic_trc.h | 4 +-
> 16 files changed, 48 insertions(+), 506 deletions(-)
>