From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752609AbdJKRpc (ORCPT ); Wed, 11 Oct 2017 13:45:32 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:38777 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752220AbdJKRpb (ORCPT ); Wed, 11 Oct 2017 13:45:31 -0400 To: Alim Akhtar Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, vinholikatti@gmail.com, martin.petersen@oracle.com, subhashj@codeaurora.org, Bart.VanAssche@wdc.com Subject: Re: [PATCH v2 1/4] scsi: ufs: Change HCI macro to actual bit position From: "Martin K. Petersen" Organization: Oracle Corporation References: <1507044085-16905-1-git-send-email-alim.akhtar@samsung.com> Date: Wed, 11 Oct 2017 13:45:18 -0400 In-Reply-To: <1507044085-16905-1-git-send-email-alim.akhtar@samsung.com> (Alim Akhtar's message of "Tue, 03 Oct 2017 20:51:22 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alim, > Currently UFS HCI uses UFS_BIT() macro to get various bit position for > the hardware registers status bits. Which makes code longer instead of > shorter. This macro does not improve code readability as well. Lets > re-write these macro definition with the actual bit position. Applied patches 1-4 to 4.15/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering