From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751473AbdFZRLr (ORCPT ); Mon, 26 Jun 2017 13:11:47 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:33995 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101AbdFZRLm (ORCPT ); Mon, 26 Jun 2017 13:11:42 -0400 To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Douglas Miller , "James E.J. Bottomley" , "Martin K. Petersen" , Hannes Reinecke , linux-scsi@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] virtio_scsi: let host do exception handling From: "Martin K. Petersen" Organization: Oracle Corporation References: <20170621143546.5826-1-pbonzini@redhat.com> Date: Mon, 26 Jun 2017 13:11:27 -0400 In-Reply-To: <20170621143546.5826-1-pbonzini@redhat.com> (Paolo Bonzini's message of "Wed, 21 Jun 2017 16:35:46 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paolo, > virtio_scsi tries to do exception handling after the default 30 > seconds timeout expires. However, it's better to let the host control > the timeout, otherwise with a heavy I/O load it is likely that an > abort will also timeout. This leads to fatal errors like filesystems > going offline. > > Disable the 'sd' timeout and allow the host to do exception handling, > following the precedent of the storvsc driver. Applied to 4.13/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering