From: Sven Schnelle <svens@linux.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Mark Rutland <mark.rutland@arm.com>,
Andy Lutomirski <luto@kernel.org>,
linux-s390@vger.kernel.org, hca@linux.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] entry: move the exit path to header files
Date: Wed, 17 May 2023 07:45:32 +0200 [thread overview]
Message-ID: <yt9dmt23lddv.fsf@linux.ibm.com> (raw)
In-Reply-To: <20230516164221.GA2602133@hirez.programming.kicks-ass.net> (Peter Zijlstra's message of "Tue, 16 May 2023 18:42:21 +0200")
Peter Zijlstra <peterz@infradead.org> writes:
> On Tue, May 16, 2023 at 03:38:09PM +0200, Sven Schnelle wrote:
>> @@ -465,4 +470,175 @@ irqentry_state_t noinstr irqentry_nmi_enter(struct pt_regs *regs);
>> */
>> void noinstr irqentry_nmi_exit(struct pt_regs *regs, irqentry_state_t irq_state);
>>
>> +static unsigned long exit_to_user_mode_loop(struct pt_regs *regs,
>> + unsigned long ti_work)
>
> Should these things not grow __always_inline/inline when moved into a header?
Yes, indeed. I missed that while doing a quick move of the functions for
testing. I'll fix that when doing a proper patch set for submission.
>> +{
>
>> +}
>> +
>> +
>> +static void exit_to_user_mode_prepare(struct pt_regs *regs)
>
> idem
>
>> +{
>
>> +}
>
>> +static void syscall_exit_work(struct pt_regs *regs, unsigned long work)
>
> and more..
>
>> +{
>
>> +}
>> +
next prev parent reply other threads:[~2023-05-17 5:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 13:38 [RFC 0/2] allow to inline generic entry Sven Schnelle
2023-05-16 13:38 ` [PATCH 1/2] entry: move the exit path to header files Sven Schnelle
2023-05-16 16:42 ` Peter Zijlstra
2023-05-16 20:20 ` Eric W. Biederman
2023-05-17 5:45 ` Sven Schnelle [this message]
2023-05-16 16:52 ` kernel test robot
2023-05-16 18:33 ` kernel test robot
2023-05-16 19:01 ` kernel test robot
2023-05-16 13:38 ` [PATCH 2/2] entry: move the enter " Sven Schnelle
2023-05-16 19:55 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yt9dmt23lddv.fsf@linux.ibm.com \
--to=svens@linux.ibm.com \
--cc=ebiederm@xmission.com \
--cc=frederic@kernel.org \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).