From: Sven Schnelle <svens@linux.ibm.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
linux-s390@vger.kernel.org, Yangbo Lu <yangbo.lu@nxp.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ptp: Add clock name to uevent
Date: Wed, 16 Oct 2024 07:20:24 +0200 [thread overview]
Message-ID: <yt9dr08gfwtj.fsf@linux.ibm.com> (raw)
In-Reply-To: <Zw81Nlx9OF-PveY0@hoboy.vegasvil.org> (Richard Cochran's message of "Tue, 15 Oct 2024 20:38:30 -0700")
Richard Cochran <richardcochran@gmail.com> writes:
> On Tue, Oct 15, 2024 at 02:43:28PM +0200, Andrew Lunn wrote:
>> * @name: A short "friendly name" to identify the clock and to
>> * help distinguish PHY based devices from MAC based ones.
>> * The string is not meant to be a unique id.
>>
>> If the name is not unique, you probably should not be using it for
>> udev naming.
>
> +1
>
> Maybe the name is unique for s390, but it will not be in general.
As already written to Greg, i will drop this Patch. The name is unique,
i was just not aware that the clock_name attribute is present in sysfs.
next prev parent reply other threads:[~2024-10-16 5:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241015084728.1833876-1-svens@linux.ibm.com>
2024-10-15 8:47 ` [PATCH 1/3] s390/time: Add clocksource id to TOD clock Sven Schnelle
2024-10-15 8:47 ` [PATCH 2/3] ptp: Add clock name to uevent Sven Schnelle
2024-10-15 12:43 ` Andrew Lunn
2024-10-16 3:38 ` Richard Cochran
2024-10-16 5:20 ` Sven Schnelle [this message]
2024-10-15 8:47 ` [PATCH 3/3] s390/time: Add PtP driver Sven Schnelle
2024-10-15 22:13 ` Jeff Johnson
2024-10-15 10:54 [PATCH RESEND 0/3] PtP driver for s390 clocks Sven Schnelle
2024-10-15 10:54 ` [PATCH 2/3] ptp: Add clock name to uevent Sven Schnelle
2024-10-15 10:59 ` Greg Kroah-Hartman
2024-10-15 12:02 ` Sven Schnelle
2024-10-15 12:16 ` Greg Kroah-Hartman
2024-10-15 12:19 ` Sven Schnelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yt9dr08gfwtj.fsf@linux.ibm.com \
--to=svens@linux.ibm.com \
--cc=andrew@lunn.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox