From: Sven Schnelle <svens@linux.ibm.com>
To: Donghai Qiao <dqiao@redhat.com>
Cc: akpm@linux-foundation.org, sfr@canb.auug.org.au, arnd@arndb.de,
peterz@infradead.org, heying24@huawei.com,
andriy.shevchenko@linux.intel.com, axboe@kernel.dk,
rdunlap@infradead.org, tglx@linutronix.de, gor@linux.ibm.com,
donghai.w.qiao@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 00/11] smp: cross CPU call interface
Date: Wed, 18 May 2022 08:19:43 +0200 [thread overview]
Message-ID: <yt9dy1yz1hxc.fsf@linux.ibm.com> (raw)
In-Reply-To: <20220517180326.997129-1-dqiao@redhat.com> (Donghai Qiao's message of "Tue, 17 May 2022 14:03:15 -0400")
Donghai Qiao <dqiao@redhat.com> writes:
> The motivation of this patch set is intended to make the existing
> cross CPU call mechanism become a formal interface, more friendly
> to the kernel developers.
>
> For the simplicity self-explanatory less code redundancy and no
> ambiguity, the set of functions below can satisfy any existing
> demand for cross call, at the meantime they still carry over the
> same semantics and the similar parameter lists.
> [..]
With this patchset applied i see the following splat on s390 when the
ftrace selftests are run:
[ 1.007231] Running postponed tracer tests:
[ 1.007398] Testing tracer function:
[ 1.036267] Callback from call_rcu_tasks() invoked.
[ 1.117709] BUG: using smp_processor_id() in preemptible [00000000] code: swapper/0/1
[ 1.117737] caller is __smp_call_mask_cond+0x42/0x5f8
[ 1.117751] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.18.0-rc7-00017-g9cc3e6b66c62 #789
[ 1.117760] Hardware name: IBM 3906 M04 704 (z/VM 7.1.0)
[ 1.117769] Call Trace:
[ 1.117777] [<000000000f571e54>] dump_stack_lvl+0xac/0x100
[ 1.117788] [<000000000f576eec>] check_preemption_disabled+0xf4/0xf8
[ 1.117798] [<000000000e94eb72>] __smp_call_mask_cond+0x42/0x5f8
[ 1.117808] [<000000000e94f35c>] smp_call_mask_others+0x54/0x70
[ 1.117818] [<000000000e9a8d5e>] ftrace_modify_all_code+0x146/0x170
[ 1.117831] [<000000000e9a8e70>] ftrace_run_update_code+0x30/0x88
[ 1.117842] [<000000000e9ad3a2>] ftrace_startup+0xea/0x1a0
[ 1.117852] [<000000000e9ad498>] register_ftrace_function+0x40/0x88
[ 1.117863] [<000000000e9ccaa8>] function_trace_init+0x90/0x108
[ 1.117897] [<00000000102957aa>] trace_selftest_startup_function+0x6a/0x338
[ 1.117910] [<000000000f56149a>] run_tracer_selftest+0x11a/0x1b0
[ 1.117934] [<0000000010294fe8>] init_trace_selftests+0x90/0x140
[ 1.117965] [<000000000e808aa8>] do_one_initcall+0x78/0x390
[ 1.117996] [<0000000010280804>] do_initcalls+0x12c/0x150
[ 1.118009] [<0000000010280af8>] kernel_init_freeable+0x250/0x290
[ 1.118018] [<000000000f5770de>] kernel_init+0x2e/0x170
[ 1.118028] [<000000000e80b924>] __ret_from_fork+0x3c/0x58
[ 1.118038] [<000000000f5881ea>] ret_from_fork+0xa/0x40
[ 1.118049] 2 locks held by swapper/0/1:
[ 1.118058] #0: 000000001012bae0 (trace_types_lock){+.+.}-{3:3}, at: init_trace_selftests+0x30/0x140
[ 1.118085] #1: 000000001012b698 (ftrace_lock){+.+.}-{3:3}, at: register_ftrace_function+0x32/0x88
next prev parent reply other threads:[~2022-05-18 6:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 18:03 [PATCH v3 00/11] smp: cross CPU call interface Donghai Qiao
2022-05-17 18:03 ` [PATCH v3 01/11] smp: consolidate the structure definitions to smp.h Donghai Qiao
2022-05-18 9:02 ` Christoph Hellwig
2022-05-17 18:03 ` [PATCH v3 02/11] smp: the definitions of cross call interface Donghai Qiao
2022-05-17 18:03 ` [PATCH v3 03/11] smp: remove SCF_WAIT and SCF_RUN_LOCAL Donghai Qiao
2022-05-17 18:03 ` [PATCH v3 04/11] smp: replace smp_call_function_single() with smp_call() Donghai Qiao
2022-05-17 18:03 ` [PATCH v3 05/11] smp: replace smp_call_function_single_async with smp_call_csd Donghai Qiao
2022-05-17 18:03 ` [PATCH v3 06/11] smp: use smp_call_csd() from irq_work.c and core.c Donghai Qiao
2022-05-17 18:03 ` [PATCH v3 07/11] smp: eliminate smp_call_function_any Donghai Qiao
2022-05-18 19:39 ` kernel test robot
2022-05-17 18:03 ` [PATCH v3 08/11] smp: replace smp_call_function_many_cond() with __smp_call_mask_cond() Donghai Qiao
2022-05-18 20:09 ` kernel test robot
2022-05-17 18:03 ` [PATCH v3 09/11] smp: replace smp_call_function_single_async with smp_call_csd Donghai Qiao
2022-05-17 18:03 ` [PATCH v3 10/11] smp: replace smp_call_function_single() with smp_call() Donghai Qiao
2022-05-17 18:03 ` [PATCH v3 11/11] smp: up.c to adopt the same format of cross CPU call Donghai Qiao
2022-05-18 6:19 ` Sven Schnelle [this message]
2022-05-18 9:04 ` [PATCH v3 00/11] smp: cross CPU call interface Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yt9dy1yz1hxc.fsf@linux.ibm.com \
--to=svens@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=donghai.w.qiao@gmail.com \
--cc=dqiao@redhat.com \
--cc=gor@linux.ibm.com \
--cc=heying24@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox