From: Keith Packard <keithp@keithp.com>
To: Scott Ashcroft <scott.ashcroft@talk21.com>, jbarnes@virtuousgeek.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: Oops in i915 intel_init_clock_gating
Date: Sat, 04 Jun 2011 23:22:31 -0700 [thread overview]
Message-ID: <yunboycol08.fsf@aiko.keithp.com> (raw)
In-Reply-To: <327832.31822.qm@web87014.mail.ird.yahoo.com>
[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]
On Sun, 5 Jun 2011 01:02:35 +0100 (BST), Scott Ashcroft <scott.ashcroft@talk21.com> wrote:
> Looks like the following commit:
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=6067aaeadb5b3df26f27ac827256b1ef01e674f5
>
>
> didn't cope with the pineview case so dev_priv->display.init_clock_gating is
> NULL causing an Oops.
>
> The old code didn't seem to do anything for pineview so I wrapped the call with
> a simple NULL check but I'm not sure if that's the correct fix.
A fix is on its way to master through drm:
95e0ee92d3a605de75a633dd2360700595d5a8ad
drm/i915: fix regression after clock gating init split
During the refactoring in revision 6067aaeadb5b3df26f27ac827256b1ef01e674f5,
the intel_enable_clock_gating was split up into several functions that are
then called indirectly. However, which function to call was not specified for
the IS_PINEVIEW() case. This patch specifies the correct gating function.
--
keith.packard@intel.com
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2011-06-05 6:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-05 0:02 Oops in i915 intel_init_clock_gating Scott Ashcroft
2011-06-05 6:22 ` Keith Packard [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-06-15 20:08 Alan Stern
2011-06-15 20:32 ` Jesse Barnes
2011-06-15 21:14 ` Alan Stern
2011-06-22 18:12 ` Keith Packard
2011-06-22 19:04 ` Alan Stern
2011-06-23 16:52 ` Florian Mickler
2011-06-23 17:11 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yunboycol08.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=scott.ashcroft@talk21.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox