From: Keith Packard <keithp@keithp.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Alex Davis <alex14641@yahoo.com>,
Kamal Mostafa <kamal@canonical.com>,
mjg@redhat.com
Subject: Re: [PATCH] drm/i915: Fix inconsistent backlight level during disabled
Date: Thu, 17 Nov 2011 13:00:35 -0800 [thread overview]
Message-ID: <yund3cqcvm4.fsf@aiko.keithp.com> (raw)
In-Reply-To: <s5hboscpexg.wl%tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 574 bytes --]
On Wed, 16 Nov 2011 10:58:03 +0100, Takashi Iwai <tiwai@suse.de> wrote:
> When the brightness property is inquired while the backlight is disabled,
> the driver returns a wrong value (zero) because it probes the value after
> the backlight was turned off. This caused a black screen even after the
> backlight is enabled again. It should return the internal backlight_level
> instead, so that it won't be influenced by the backlight-enable state.
Yes, this looks correct by inspection to me. I'll stick it into
drm-intel-fixes.
--
keith.packard@intel.com
[-- Attachment #2: Type: application/pgp-signature, Size: 827 bytes --]
next prev parent reply other threads:[~2011-11-17 21:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 9:58 [PATCH] drm/i915: Fix inconsistent backlight level during disabled Takashi Iwai
2011-11-16 13:19 ` Alex Davis
2011-11-20 16:28 ` Alex Davis
2011-11-17 21:00 ` Keith Packard [this message]
2011-11-19 20:02 ` Woody Suwalski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yund3cqcvm4.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=alex14641@yahoo.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kamal@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox