public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Keith Packard <keithp@keithp.com>
To: Gene Heskett <gene.heskett@gmail.com>,
	Ben Brewer <ben.brewer@codethink.co.uk>,
	dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: i915 SSC Patch
Date: Fri, 29 Jul 2011 15:18:05 -0700	[thread overview]
Message-ID: <yund3gshgte.fsf@aiko.keithp.com> (raw)
In-Reply-To: <201107291801.40049.gene.heskett@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1396 bytes --]

On Fri, 29 Jul 2011 18:01:39 -0400, Gene Heskett <gene.heskett@gmail.com> wrote:
> On Friday, July 29, 2011, Keith Packard wrote:
> >On Fri, 29 Jul 2011 13:55:35 +0100, Ben Brewer 
> <ben.brewer@codethink.co.uk> wrote:
> >> I've added a global SSC (Spread Spectrum Clock) parameter to the i915
> >> driver, since having SSC enabled breaks (distorts) VGA output on some
> >> Core i5/i7 chips (see
> >> https://bugs.freedesktop.org/show_bug.cgi?id=38750). SSC is still
> >> enabled by default so the behaviour won't change but setting the
> >> global_use_ssc parameter will turn this feature off and allow affected
> >> devices to function correctly (notably the Dell Vostro 3300).
> >
> >The question I have is why is SSC enabled on the VGA output at all? I
> >don't see any way VGA could ever tolerate it.
> 
> Something does not make sense here Keith, so I'm with you, and my 
> background is from about 60 years in tv maintenance and 45 in
> broadcasting.

Right, I think the basic problem is that we aren't switching SSC on and
off based on whether there's an output which can't tolerate it. Making
this user-configurable doesn't make any sense, it clearly needs to be
done in the driver automatically, based on whether there's an analog
output running (VGA or TV).

> Hardware design error in the Dell?

Nope, just a driver bug :-)

-- 
keith.packard@intel.com

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

      reply	other threads:[~2011-07-29 22:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-29 12:55 i915 SSC Patch Ben Brewer
2011-07-29 18:45 ` Keith Packard
2011-07-29 19:02   ` Chris Wilson
2011-07-29 21:18     ` Keith Packard
2011-07-29 22:01   ` Gene Heskett
2011-07-29 22:18     ` Keith Packard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yund3gshgte.fsf@aiko.keithp.com \
    --to=keithp@keithp.com \
    --cc=ben.brewer@codethink.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gene.heskett@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox