From: Keith Packard <keithp@keithp.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Dave Airlie <airlied@redhat.com>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Hold struct_mutex during hotplug processing
Date: Tue, 26 Jul 2011 08:23:13 -0700 [thread overview]
Message-ID: <yunsjpt2hi6.fsf@aiko.keithp.com> (raw)
In-Reply-To: <CAKMK7uHO1jqUNrnqC9sd=JJ9Vr=hmAjnJ06eDYxfeyTTFAMK1w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 552 bytes --]
On Tue, 26 Jul 2011 09:24:39 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> Two things I've noticed:
> - Why not dev->mode_config.mutex?
You're right, of course. I noticed that just after posting that version
and updated it; the updated version is on my drm-intel-fixes branch
already (having been reviewed by Jesse).
> - And a nitpick: Why the dev_priv->dev indirection, when dev is
> already lying around?
All nicely cleaned up by using &mode_config->mutex instead :-)
Thanks for looking it over!
--
keith.packard@intel.com
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2011-07-26 15:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 17:10 [PATCH] drm/i915: Hold struct_mutex during hotplug processing Keith Packard
2011-07-25 17:37 ` [Intel-gfx] " Jesse Barnes
2011-07-25 17:40 ` Andrew Lutomirski
2011-07-25 17:55 ` Keith Packard
2011-07-26 2:52 ` Andrew Lutomirski
2011-07-26 5:54 ` Keith Packard
2011-07-26 12:35 ` Andrew Lutomirski
2011-07-26 7:24 ` Daniel Vetter
2011-07-26 15:23 ` Keith Packard [this message]
2011-07-26 19:12 ` Jesse Barnes
2011-07-27 9:21 ` Keith Packard
2011-07-27 16:03 ` Jesse Barnes
2011-07-28 22:50 ` Keith Packard
2011-07-29 10:25 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yunsjpt2hi6.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox