From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757568Ab1I3SCf (ORCPT ); Fri, 30 Sep 2011 14:02:35 -0400 Received: from home.keithp.com ([63.227.221.253]:41810 "EHLO keithp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755626Ab1I3SCe (ORCPT ); Fri, 30 Sep 2011 14:02:34 -0400 From: Keith Packard To: Daniel Vetter Cc: Dave Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 07/21] drm/i915: Check for eDP inside intel_edp_panel_vdd_on/off In-Reply-To: <20110930171355.GG2859@phenom.ffwll.local> References: <20110923085243.6e4b7b4c@jbarnes-x220> <1317344993-24945-1-git-send-email-keithp@keithp.com> <1317344993-24945-8-git-send-email-keithp@keithp.com> <20110930171355.GG2859@phenom.ffwll.local> User-Agent: Notmuch/0.6.1-66-ga900dda (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu) Date: Fri, 30 Sep 2011 11:02:30 -0700 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Transfer-Encoding: quoted-printable On Fri, 30 Sep 2011 19:13:55 +0200, Daniel Vetter wrote: > Why not also move the id_edp check into edp_panel_on|off like for the vdd > functions? This way it looks a bit inconsistent ... Yeah, I can do that. May mean a few redundant checks, but they're cheap. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFOhgQ3Qp8BWwlsTdMRAhK7AKCrZ2qRmBiGwPe7dwD+f9sUvgtVGgCgwCab hm4Yv12zNdGnVFwjAH1VBiI= =AzkG -----END PGP SIGNATURE----- --=-=-=--