From: Keith Packard <keithp@keithp.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, airlied@linux.ie,
dri-devel@lists.freedesktop.org
Cc: kosaki.motohiro@jp.fujitsu.com
Subject: Re: [PATCH] i915: slab shrinker have to return -1 if it can't shrink any objects
Date: Wed, 29 Jun 2011 20:53:54 -0700 [thread overview]
Message-ID: <yuny60kt1nx.fsf@aiko.keithp.com> (raw)
In-Reply-To: <4E0444CA.3080407@jp.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
On Fri, 24 Jun 2011 17:03:22 +0900, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> Now, i915_gem_inactive_shrink() should return -1 instead of 0 if it
> can't take a lock. Otherwise, vmscan is getting a lot of confusing
> because vmscan can't distinguish "can't take a lock temporary" and
> "we've shrank all of i915 objects".
This doesn't look like the cleanest change possible. I think it would be
better if the shrink function could uniformly return an error
indication so that we wouldn't need the weird looking conditional return.
--
keith.packard@intel.com
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2011-06-30 3:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 8:03 [PATCH] i915: slab shrinker have to return -1 if it can't shrink any objects KOSAKI Motohiro
2011-06-30 3:53 ` Keith Packard [this message]
2011-06-30 8:55 ` [PATCH] i915: slab shrinker have to return -1 if it cant " Chris Wilson
2011-07-12 9:36 ` KOSAKI Motohiro
2011-07-12 10:06 ` Chris Wilson
2011-07-13 0:19 ` KOSAKI Motohiro
2011-07-13 7:41 ` Chris Wilson
2011-07-13 8:19 ` KOSAKI Motohiro
2011-07-13 8:40 ` Chris Wilson
2011-07-13 11:34 ` Dave Chinner
2011-07-13 10:42 ` Dave Chinner
2011-07-14 2:48 ` KOSAKI Motohiro
2011-07-14 3:47 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yuny60kt1nx.fsf@aiko.keithp.com \
--to=keithp@keithp.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox