Re: [PATCH]O18.1int

Con Kolivas
2003-08-23T12:18:27Z

On Sat, 23 Aug 2003 19:18, Nick Piggin wrote:
> Hi
> I don't know what is preferred on lkml, but I dislike mixing booleans
> and integer arithmetic.
>
> if (!LOW_CREDIT(prev))
> prev->interactive_credit--;
>
> Easier to read IMO.

I agree. I only mixed them because of my (perhaps false) belief that it's less
of a hit not having another if.. branch point. Then again today's compilers
probably optimise it out anyway.

Con