From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933626AbcAKOON (ORCPT ); Mon, 11 Jan 2016 09:14:13 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:55677 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932829AbcAKOOJ convert rfc822-to-8bit (ORCPT ); Mon, 11 Jan 2016 09:14:09 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Viresh Kumar Cc: Viresh Kumar , Andy Shevchenko , Dan Williams , Vinod Koul , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks References: <1452517469-26922-1-git-send-email-mans@mansr.com> <1452517469-26922-3-git-send-email-mans@mansr.com> <20160111141048.GB1084@ubuntu> Date: Mon, 11 Jan 2016 14:14:00 +0000 In-Reply-To: <20160111141048.GB1084@ubuntu> (Viresh Kumar's message of "Mon, 11 Jan 2016 19:40:48 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Viresh Kumar writes: > On 11-01-16, 13:04, Mans Rullgard wrote: >> Cyclic transfer callbacks rely on block completion interrupts which were >> disabled in commit ff7b05f29fd4 ("dmaengine/dw_dmac: Don't handle block >> interrupts"). This re-enables block interrupts so the cyclic callbacks >> can work. Other transfer types are not affected as they set the INT_EN >> bit only on the last block. >> >> Fixes: ff7b05f29fd4 ("dmaengine/dw_dmac: Don't handle block interrupts") >> Signed-off-by: Mans Rullgard >> --- >> Changes: >> - new patch >> --- >> drivers/dma/dw/core.c | 21 +++++++++++++++------ >> 1 file changed, 15 insertions(+), 6 deletions(-) > > Reviewed-by: Viresh Kumar > > BTW, Shouldn't you mark these for stable trees as well ? :) Probably. Some maintainers prefer to do that themselves, but apparently you're not one of them. -- Måns Rullgård