From: "Måns Rullgård" <mans@mansr.com>
To: Stefan Agner <stefan@agner.ch>
Cc: linux@armlinux.org.uk, arnd@arndb.de, ard.biesheuvel@linaro.org,
robin.murphy@arm.com, nicolas.pitre@linaro.org,
f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, kgene@kernel.org,
krzk@kernel.org, robh@kernel.org, ssantosh@kernel.org,
jason@lakedaemon.net, andrew@lunn.ch,
gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com,
tony@atomide.com, marc.w.gonzalez@free.fr,
ndesaulniers@google.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: use arch_extension directive instead of arch argument
Date: Sat, 23 Mar 2019 16:02:49 +0000 [thread overview]
Message-ID: <yw1xa7hlzihi.fsf@mansr.com> (raw)
In-Reply-To: <9641c58c03720104186a797a96e30a52ae9805e4.1553356359.git.stefan@agner.ch> (Stefan Agner's message of "Sat, 23 Mar 2019 16:52:56 +0100")
Stefan Agner <stefan@agner.ch> writes:
> The LLVM Target parser currently does not allow to specify the security
> extension as part of -march (see also LLVM Bug 40186 [0]). When trying
> to use Clang with LLVM's integrated assembler, this leads to a build
> errors such as this:
> clang-8: error: the clang compiler does not support '-Wa,-march=armv7-a+sec'
>
> Use ".arch_extension sec" to enable the security extension in a more
> portable fasion.
>
> Note that this is technically not exactly the same as the old code
> checked for availabilty of the security extension by calling as-instr.
> However, there are already other sites which use ".arch_extension sec"
> unconditionally, hence de-facto we need an assembler capable of
> ".arch_extension sec" already today (arch/arm/mm/proc-v7.S). The
> arch extension "sec" is available since binutils 2.21 according to
> its documentation [1].
>
> [0] https://bugs.llvm.org/show_bug.cgi?id=40186
> [1] https://sourceware.org/binutils/docs-2.21/as/ARM-Options.html
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> arch/arm/mach-bcm/Makefile | 3 ---
> arch/arm/mach-bcm/bcm_kona_smc.c | 2 --
> arch/arm/mach-exynos/Makefile | 4 ----
> arch/arm/mach-exynos/exynos-smc.S | 2 +-
> arch/arm/mach-exynos/sleep.S | 2 +-
> arch/arm/mach-highbank/Makefile | 3 ---
> arch/arm/mach-highbank/smc.S | 2 +-
> arch/arm/mach-keystone/Makefile | 3 ---
> arch/arm/mach-keystone/smc.S | 1 +
> arch/arm/mach-omap2/Makefile | 8 --------
> arch/arm/mach-omap2/omap-headsmp.S | 1 +
> arch/arm/mach-omap2/omap-smc.S | 2 +-
> arch/arm/mach-omap2/sleep34xx.S | 1 +
> arch/arm/mach-omap2/sleep43xx.S | 1 +
> arch/arm/mach-omap2/sleep44xx.S | 1 +
> arch/arm/mach-tango/Makefile | 3 ---
> arch/arm/mach-tango/smc.S | 1 +
> 17 files changed, 10 insertions(+), 30 deletions(-)
[...]
> diff --git a/arch/arm/mach-tango/Makefile b/arch/arm/mach-tango/Makefile
> index da6c633d3cc0..97cd04508fa1 100644
> --- a/arch/arm/mach-tango/Makefile
> +++ b/arch/arm/mach-tango/Makefile
> @@ -1,7 +1,4 @@
> # SPDX-License-Identifier: GPL-2.0
> -plus_sec := $(call as-instr,.arch_extension sec,+sec)
> -AFLAGS_smc.o := -Wa,-march=armv7-a$(plus_sec)
> -
> obj-y += setup.o smc.o
> obj-$(CONFIG_SMP) += platsmp.o
> obj-$(CONFIG_SUSPEND) += pm.o
> diff --git a/arch/arm/mach-tango/smc.S b/arch/arm/mach-tango/smc.S
> index 361a8dc89804..cf2d21e5226c 100644
> --- a/arch/arm/mach-tango/smc.S
> +++ b/arch/arm/mach-tango/smc.S
> @@ -1,6 +1,7 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> #include <linux/linkage.h>
>
> + .arch_extension sec
> ENTRY(tango_smc)
> push {lr}
> mov ip, r1
For Tango:
Acked-by: Mans Rullgard <mans@mansr.com>
--
Måns Rullgård
next prev parent reply other threads:[~2019-03-23 16:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 15:52 [PATCH 1/3] ARM: use arch_extension directive instead of arch argument Stefan Agner
2019-03-23 15:52 ` [PATCH 2/3] ARM: mvebu: drop unnecessary label Stefan Agner
2019-03-23 17:55 ` nicolas.pitre
2019-03-23 15:52 ` [PATCH 3/3] ARM: mvebu: prefix coprocessor operand with p Stefan Agner
2019-03-23 17:56 ` nicolas.pitre
2019-03-23 16:02 ` Måns Rullgård [this message]
2019-03-23 20:06 ` [PATCH 1/3] ARM: use arch_extension directive instead of arch argument Arnd Bergmann
2019-03-24 21:50 ` Stefan Agner
2019-03-31 17:34 ` Arnd Bergmann
2019-04-08 20:23 ` Stefan Agner
2019-03-25 10:53 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xa7hlzihi.fsf@mansr.com \
--to=mans@mansr.com \
--cc=andrew@lunn.ch \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marc.w.gonzalez@free.fr \
--cc=ndesaulniers@google.com \
--cc=nicolas.pitre@linaro.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sbranden@broadcom.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=ssantosh@kernel.org \
--cc=stefan@agner.ch \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox