From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E0CDEB64DD for ; Mon, 26 Jun 2023 12:24:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229677AbjFZMYV convert rfc822-to-8bit (ORCPT ); Mon, 26 Jun 2023 08:24:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229651AbjFZMYD (ORCPT ); Mon, 26 Jun 2023 08:24:03 -0400 Received: from unicorn.mansr.com (unicorn.mansr.com [81.2.72.234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BBD12126; Mon, 26 Jun 2023 05:22:25 -0700 (PDT) Received: from raven.mansr.com (raven.mansr.com [81.2.72.235]) by unicorn.mansr.com (Postfix) with ESMTPS id 8A3AD15360; Mon, 26 Jun 2023 13:21:33 +0100 (BST) Received: by raven.mansr.com (Postfix, from userid 51770) id 144A4219FD1; Mon, 26 Jun 2023 13:21:33 +0100 (BST) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Samuel Holland Cc: Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , linux-sunxi@lists.linux.dev, Michael Turquette , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Boyd , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/4] clk: sunxi-ng: Convert early providers to platform drivers References: <20211119033338.25486-1-samuel@sholland.org> <20211119033338.25486-4-samuel@sholland.org> Date: Mon, 26 Jun 2023 13:21:33 +0100 In-Reply-To: <20211119033338.25486-4-samuel@sholland.org> (Samuel Holland's message of "Thu, 18 Nov 2021 21:33:36 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Samuel Holland writes: > The PRCM CCU drivers depend on clocks provided by other CCU drivers. For > example, the sun8i-r-ccu driver uses the "pll-periph" clock provided by > the SoC's main CCU. > > However, sun8i-r-ccu is an early OF clock provider, and many of the > main CCUs (e.g. sun50i-a64-ccu) use platform drivers. This means that > the consumer clocks will be orphaned until the supplier driver is bound. > This can be avoided by converting the remaining CCUs to use platform > drivers. Then fw_devlink will ensure the drivers are bound in the > optimal order. > > The sun5i CCU is the only one which actually needs to be an early clock > provider, because it provides the clock for the system timer. That one > is left alone. > > Signed-off-by: Samuel Holland > --- > > (no changes since v1) > > drivers/clk/sunxi-ng/Kconfig | 20 ++++---- > drivers/clk/sunxi-ng/ccu-sun4i-a10.c | 58 +++++++++++++-------- > drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c | 56 ++++++++++++-------- > drivers/clk/sunxi-ng/ccu-sun50i-h616.c | 33 ++++++++---- > drivers/clk/sunxi-ng/ccu-sun6i-a31.c | 40 +++++++++++---- > drivers/clk/sunxi-ng/ccu-sun8i-a23.c | 35 +++++++++---- > drivers/clk/sunxi-ng/ccu-sun8i-a33.c | 40 +++++++++++---- > drivers/clk/sunxi-ng/ccu-sun8i-h3.c | 62 ++++++++++++++-------- > drivers/clk/sunxi-ng/ccu-sun8i-r.c | 65 ++++++++++++++---------- > drivers/clk/sunxi-ng/ccu-sun8i-v3s.c | 57 +++++++++++++-------- > drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c | 38 ++++++++++---- > 11 files changed, 332 insertions(+), 172 deletions(-) This broke the hstimer clocksource on A20 since it requires a clock provided by the sun4i ccu driver. -- Måns Rullgård