From: "Måns Rullgård" <mans@mansr.com>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Lee Jones <lee@kernel.org>, Jingoo Han <jingoohan1@gmail.com>,
Helge Deller <deller@gmx.de>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] backlight: led_bl: fix initial power state
Date: Wed, 05 Jul 2023 15:51:05 +0100 [thread overview]
Message-ID: <yw1xfs62za1y.fsf@mansr.com> (raw)
In-Reply-To: <20230705144406.GA9021@aspen.lan> (Daniel Thompson's message of "Wed, 5 Jul 2023 15:44:06 +0100")
Daniel Thompson <daniel.thompson@linaro.org> writes:
> On Wed, Jul 05, 2023 at 03:36:46PM +0100, Måns Rullgård wrote:
>> Daniel Thompson <daniel.thompson@linaro.org> writes:
>>
>> > On Wed, Jul 05, 2023 at 03:24:14PM +0100, Mans Rullgard wrote:
>> >> The condition for the initial power state based on the default
>> >> brightness value is reversed. Fix it.
>> >>
>> >> Furthermore, use the actual state of the LEDs rather than the default
>> >> brightness specified in the devicetree as the latter should not cause
>> >> the backlight to be automatically turned on.
>> >>
>> >> If the backlight device is not linked to any display, set the initial
>> >> power to on unconditionally.
>> >>
>> >> Fixes: ae232e45acf9 ("backlight: add led-backlight driver")
>> >> Signed-off-by: Mans Rullgard <mans@mansr.com>
>> >> ---
>> >> Changes in v3:
>> >> - Add comment
>> >
>> > This mismatches the subject line ;-) but I can live with that if Lee
>> > and Jingoo can!
>>
>> Does it not fix it? If you think the subject is misleading, feel free
>> to change it.
>
> The bit that goes into version control is fine!
>
> However without '[PATCH v3]' on the subject line for the initial patch
> there is a risk this thread will get overlooked and not queued[1].
Oh, I see now I forgot to add the v3 tag. Sorry about that.
--
Måns Rullgård
next prev parent reply other threads:[~2023-07-05 14:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 14:24 [PATCH] backlight: led_bl: fix initial power state Mans Rullgard
2023-07-05 14:33 ` Daniel Thompson
2023-07-05 14:36 ` Måns Rullgård
2023-07-05 14:44 ` Daniel Thompson
2023-07-05 14:51 ` Måns Rullgård [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-07-04 14:07 Mans Rullgard
2023-07-04 15:03 ` Daniel Thompson
2023-07-04 15:31 ` Måns Rullgård
2023-07-04 15:40 ` Daniel Thompson
2023-07-04 17:07 ` Sam Ravnborg
2023-07-05 14:07 ` Daniel Thompson
2023-07-05 17:56 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xfs62za1y.fsf@mansr.com \
--to=mans@mansr.com \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox