From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754543AbcAHLS4 (ORCPT ); Fri, 8 Jan 2016 06:18:56 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:42928 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751780AbcAHLSz convert rfc822-to-8bit (ORCPT ); Fri, 8 Jan 2016 06:18:55 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Borislav Petkov Cc: Thomas Voegtle , Markus Trippelsdorf , linux-kernel@vger.kernel.org Subject: Re: x86/microcode update on systems without INITRD References: <20151119214301.GA318@x4> <20151119215543.GA4926@pd.tnic> <20151119225828.GB4926@pd.tnic> <20151120071920.GA321@x4> <20151120082716.GA4028@pd.tnic> <20160107121841.GB16472@pd.tnic> <20160108105900.GA14673@pd.tnic> Date: Fri, 08 Jan 2016 11:18:51 +0000 In-Reply-To: <20160108105900.GA14673@pd.tnic> (Borislav Petkov's message of "Fri, 8 Jan 2016 11:59:00 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Borislav Petkov writes: > On Thu, Jan 07, 2016 at 01:36:00PM +0100, Thomas Voegtle wrote: >> Attached. It is a little bit unusual config without modules etc. > > Ok, I see it. > > Please do a proper patch explaining why we're changing "depends on" to > "select" and we can try it, see who complains then and why. Neither "depends on" nor "select" makes sense to me here. The driver apparently works without it, and simply having BLK_DEV_INITRD enabled doesn't prevent improper (according to some people) use of the driver. If updating microcode is inherently unsafe when a real disk is mounted, the driver ought to detect this and refuse the operation (possibly with an override option). -- Måns Rullgård