From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17B86C4CEC9 for ; Wed, 18 Sep 2019 11:00:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE0AC20856 for ; Wed, 18 Sep 2019 11:00:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727716AbfIRLA4 convert rfc822-to-8bit (ORCPT ); Wed, 18 Sep 2019 07:00:56 -0400 Received: from unicorn.mansr.com ([81.2.72.234]:38946 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726077AbfIRLAz (ORCPT ); Wed, 18 Sep 2019 07:00:55 -0400 Received: by unicorn.mansr.com (Postfix, from userid 51770) id CD3A91538A; Wed, 18 Sep 2019 12:00:53 +0100 (BST) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Markus Elfring Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Allison Randal , Greg Kroah-Hartman , Marc Gonzalez , Mauro Carvalho Chehab , Thomas Gleixner , LKML , kernel-janitors@vger.kernel.org, Bartosz Golaszewski , Himanshu Jha Subject: Re: [PATCH] media: rc: Use devm_platform_ioremap_resource() in tango_ir_probe() References: <04df8450-1b15-55ec-91e7-7d72ffbedac7@web.de> Date: Wed, 18 Sep 2019 12:00:53 +0100 In-Reply-To: <04df8450-1b15-55ec-91e7-7d72ffbedac7@web.de> (Markus Elfring's message of "Wed, 18 Sep 2019 12:37:24 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Markus Elfring writes: > From: Markus Elfring > Date: Wed, 18 Sep 2019 12:30:18 +0200 > > Simplify this function implementation by using a known wrapper function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Mans Rullgard > --- > drivers/media/rc/tango-ir.c | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) > > diff --git a/drivers/media/rc/tango-ir.c b/drivers/media/rc/tango-ir.c > index 451ec4e9dcfa..b8eb5bc4d9be 100644 > --- a/drivers/media/rc/tango-ir.c > +++ b/drivers/media/rc/tango-ir.c > @@ -157,20 +157,10 @@ static int tango_ir_probe(struct platform_device *pdev) > struct device *dev = &pdev->dev; > struct rc_dev *rc; > struct tango_ir *ir; > - struct resource *rc5_res; > - struct resource *rc6_res; > u64 clkrate, clkdiv; > int irq, err; > u32 val; > > - rc5_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!rc5_res) > - return -EINVAL; > - > - rc6_res = platform_get_resource(pdev, IORESOURCE_MEM, 1); > - if (!rc6_res) > - return -EINVAL; > - > irq = platform_get_irq(pdev, 0); > if (irq <= 0) > return -EINVAL; > @@ -179,11 +169,11 @@ static int tango_ir_probe(struct platform_device *pdev) > if (!ir) > return -ENOMEM; > > - ir->rc5_base = devm_ioremap_resource(dev, rc5_res); > + ir->rc5_base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(ir->rc5_base)) > return PTR_ERR(ir->rc5_base); > > - ir->rc6_base = devm_ioremap_resource(dev, rc6_res); > + ir->rc6_base = devm_platform_ioremap_resource(pdev, 1); > if (IS_ERR(ir->rc6_base)) > return PTR_ERR(ir->rc6_base); > > -- > 2.23.0 > -- Måns Rullgård