Re: [PATCH] Configurable Magic Sysrq

["Måns Rullgård" <mru@inprovide.com>]

Jan Kara <jack@suse.cz> writes:

>> Andrew Morton <akpm@osdl.org> writes:
>> 
>> > Jan Kara <jack@suse.cz> wrote:
>> >>
>> >>    I know about a few people who would like to use some functionality of
>> >>  the Magic Sysrq but don't want to enable all the functions it provides.
>> >
>> > That's a new one.  Can you tell us more about why people want to do such a
>> > thing?
>> >
>> >>  So I wrote a patch which should allow them to do so. It allows to
>> >>  configure available functions of Sysrq via /proc/sys/kernel/sysrq (the
>> >>  interface is backward compatible). If you think it's useful then use it :)
>> >>  Andrew, do you think it can go into mainline or it's just an overdesign?
>> >
>> > Patch looks reasonable - we just need to decide whether the requirement
>> > warrants its inclusion.
>> >
>> > There have been a few changes in the sysrq code since 2.6.9 and there are
>> > more changes queued up in -mm.  The patch applies OK, but it'll need
>> > checking and redoing.  There's a new `sysrq-f' command in the pipeline
>> > which causes a manual oom-killer call.
>> 
>> See also the patch I just posted to lkml.
>   OK, Andrew, are you accepting the patch? The sysrq should probably go
> into SYSRQ_ENABLE_SIGNAL group...

Don't miss the update I posted a few minutes later.

>> I also thought of an improved way of selecting keys to enable.
>> Instead of an arbitrary bitmask, would it be possible to simply list
>> the keys you want to enable, such as "echo sku > /proc/sys/kernel/sysrq"?
>   That would be possible of course but you'd have to do your own
> parsing in kernel and you are not supposed to change the sysrq
> setting often - usually just compute your favourite number, put it
> into boot scripts and you're done. So I'm not convinced it's useful
> very much.

I'm not likely to use either of them, so I'll leave it to you.

-- 
Måns Rullgård
mru@inprovide.com