From: "Måns Rullgård" <mans@mansr.com>
To: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Russell King <linux@arm.linux.org.uk>,
LKML <linux-kernel@vger.kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Nicolas Pitre <nico@linaro.org>, Tony Lindgren <tony@atomide.com>,
Sebastian Frias <sebastian_frias@sigmadesigns.com>
Subject: Re: [PATCH] clocksource: Store reg field within struct clocksource
Date: Wed, 18 Nov 2015 13:51:04 +0000 [thread overview]
Message-ID: <yw1xvb8zfmbb.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <564C8086.80804@sigmadesigns.com> (Marc Gonzalez's message of "Wed, 18 Nov 2015 14:43:34 +0100")
Marc Gonzalez <marc_gonzalez@sigmadesigns.com> writes:
> Since 'struct clocksource' is ____cacheline_aligned, gcc must insert
> a lot of padding between reg and clksrc in 'struct clocksource_mmio'
> (for example, L1_CACHE_BYTES = 64 on ARMv7).
>
> Storing reg within 'struct clocksource' removes unnecessary padding,
> and reg can then be grouped with other hot data.
Can you demonstrate a difference with this change? Not saying it's bad,
but it's always good to have numbers.
> A nice side-effect of this patch is making container_of() unnecessary,
> which makes the code a bit simpler.
You really need to get used to that construct.
--
Måns Rullgård
mans@mansr.com
next prev parent reply other threads:[~2015-11-18 13:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 13:43 [PATCH] clocksource: Store reg field within struct clocksource Marc Gonzalez
2015-11-18 13:51 ` Måns Rullgård [this message]
2015-11-18 17:21 ` Russell King - ARM Linux
2015-11-19 9:27 ` Marc Gonzalez
2015-11-19 10:33 ` Russell King - ARM Linux
2015-11-19 10:36 ` Thomas Gleixner
2015-11-19 10:40 ` Russell King - ARM Linux
2015-11-19 10:33 ` Thomas Gleixner
2015-11-19 10:36 ` Russell King - ARM Linux
2015-11-19 10:42 ` Thomas Gleixner
2015-11-19 11:08 ` Russell King - ARM Linux
2015-11-19 11:14 ` Thomas Gleixner
2015-11-19 12:26 ` Marc Gonzalez
2015-11-19 13:57 ` Thomas Gleixner
2015-11-24 12:36 ` Marc Gonzalez
2015-11-25 21:33 ` [tip:timers/core] timekeeping: Lift clocksource cacheline restriction tip-bot for Thomas Gleixner
2015-11-19 10:55 ` [PATCH] clocksource: Store reg field within struct clocksource Marc Gonzalez
2015-11-19 11:21 ` Russell King - ARM Linux
2015-11-19 12:41 ` Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xvb8zfmbb.fsf@unicorn.mansr.com \
--to=mans@mansr.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc_gonzalez@sigmadesigns.com \
--cc=nico@linaro.org \
--cc=sebastian_frias@sigmadesigns.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox