From: "Måns Rullgård" <mans@mansr.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Willy Tarreau <w@1wt.eu>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH 3/3] auxdisplay: charlcd: make backlight initial state configurable
Date: Wed, 06 Mar 2019 14:49:19 +0000 [thread overview]
Message-ID: <yw1xy35s3vo0.fsf@mansr.com> (raw)
In-Reply-To: <CANiq72nFOhrjN0nfBQc28dDyY0XPwWrJwWSkXv0yxGb-B2M-JQ@mail.gmail.com> (Miguel Ojeda's message of "Wed, 6 Mar 2019 10:56:21 +0100")
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> writes:
> On Fri, Mar 1, 2019 at 7:48 PM Mans Rullgard <mans@mansr.com> wrote:
>>
>> +#ifdef CONFIG_CHARLCD_BL_ON
>> +#define LCD_INIT_BL "\x1b[L+"
>> +#elif defined (CONFIG_CHARLCD_BL_FLASH)
>
> Style nitpick: no space after "elif defined". Do you mind if I change
> it before sending it to linux-next? Otherwise, looks fine to me.
> Thanks!
Of course I don't mind.
--
Måns Rullgård
next prev parent reply other threads:[~2019-03-06 14:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 18:48 [PATCH 1/3] auxdisplay: deconfuse configuration Mans Rullgard
2019-03-01 18:48 ` [PATCH 2/3] auxdisplay: charlcd: simplify init message display Mans Rullgard
2019-03-06 10:03 ` Miguel Ojeda
2019-03-01 18:48 ` [PATCH 3/3] auxdisplay: charlcd: make backlight initial state configurable Mans Rullgard
2019-03-06 9:56 ` Miguel Ojeda
2019-03-06 10:03 ` Miguel Ojeda
2019-03-06 14:49 ` Måns Rullgård [this message]
2019-03-12 15:45 ` Andy Shevchenko
2019-03-12 15:48 ` Måns Rullgård
2019-03-17 7:43 ` Miguel Ojeda
2019-03-17 16:52 ` Måns Rullgård
2019-03-06 10:14 ` [PATCH 1/3] auxdisplay: deconfuse configuration Miguel Ojeda
2019-03-06 15:08 ` Måns Rullgård
2019-03-23 14:28 ` Miguel Ojeda
2019-03-23 14:50 ` Randy Dunlap
2019-03-23 15:00 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xy35s3vo0.fsf@mansr.com \
--to=mans@mansr.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox