From: "Måns Rullgård" <mans@mansr.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wim Van Sebroeck <wim@iguana.be>,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v2 2/2] watchdog: add support for Sigma Designs SMP86xx/SMP87xx
Date: Thu, 19 Nov 2015 16:30:22 +0000 [thread overview]
Message-ID: <yw1xziyadk9t.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <564DF807.3040608@roeck-us.net> (Guenter Roeck's message of "Thu, 19 Nov 2015 08:25:43 -0800")
Guenter Roeck <linux@roeck-us.net> writes:
>> + writel(WD_CONFIG_XTAL_IN, dev->base + WD_CONFIG);
>
> What happens if the DISABLE bit was previously set (assuming
> that DISABLE means that the watchdog is disabled) ?
>
> Concern I guess would be the combination of DISABLE being set
> and WD_COUNTER at a value != 0 (say, 1). That might effectively
> auto-enable the watchdog or even reset the system.
There's no sane reason why it would be in that state, but then again
firmware authors are not sane.
How about checking the DISABLE bit, and if it's set turn off the
counter, otherwise leave it running?
--
Måns Rullgård
mans@mansr.com
next prev parent reply other threads:[~2015-11-19 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 17:55 [PATCH v2 1/2] devicetree: watchdog: add binding for Sigma Designs SMP8642 watchdog Mans Rullgard
2015-11-18 17:55 ` [PATCH v2 2/2] watchdog: add support for Sigma Designs SMP86xx/SMP87xx Mans Rullgard
2015-11-19 16:25 ` Guenter Roeck
2015-11-19 16:30 ` Måns Rullgård [this message]
2015-11-18 21:16 ` [PATCH v2 1/2] devicetree: watchdog: add binding for Sigma Designs SMP8642 watchdog Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xziyadk9t.fsf@unicorn.mansr.com \
--to=mans@mansr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox