Re: [PATCH v2 05/12] tools: ynl_gen_rst.py: Split library from command line tool

Mauro Carvalho Chehab
2025-06-14T15:01:23Z

Em Sat, 14 Jun 2025 14:34:01 +0100
Donald Hunter <donald.hunter@gmail.com> escreveu:

> On Fri, 13 Jun 2025 at 13:18, Mauro Carvalho Chehab
> <mchehab+huawei@kernel.org> wrote:
> >
> > Em Fri, 13 Jun 2025 12:13:28 +0100
> > Donald Hunter <donald.hunter@gmail.com> escreveu:
> >
> > > Mauro Carvalho Chehab <mchehab+huawei@kernel.org> writes:
> > >
> > > > As we'll be using the Netlink specs parser inside a Sphinx
> > > > extension, move the library part from the command line parser.
> > > >
> > > > No functional changes.
> > > >
> > > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> > > > ---
> > > > scripts/lib/netlink_yml_parser.py | 391 +++++++++++++++++++++++++++++
> > > > tools/net/ynl/pyynl/ynl_gen_rst.py | 374 +--------------------------
> > >
> > > I think the library code should be put in tools/net/ynl/pyynl/lib
> > > because it is YNL specific code. Maybe call it rst_generator.py
> >
> > We had a similar discussion before when we switched get_abi and
> > kernel-doc to Python. On that time, we opted to place all shared
> > Python libraries under scripts/lib.
> >
> > From my side, I don't mind having them on a different place,
> > but I prefer to see all Sphinx extensions getting libraries from
> > the same base directory.
>
> It's YNL specific code and I want to refactor it to make use of
> tools/net/ynl/pyynl/lib/nlspec.py so it definitely belongs in
> tools/net/ynl/pyynl/lib.

To avoid duplicating comments, let's discuss this at patch 12/14's
thread.

Thanks,
Mauro