From: Markus Elfring <Markus.Elfring@web.de>
To: Justin Stitt <justinstitt@google.com>,
virtualization@lists.linux.dev, linux-crypto@vger.kernel.org,
kernel-janitors@vger.kernel.org, netdev@vger.kernel.org,
cocci@inria.fr
Cc: kernel test robot <lkp@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Gonglei <arei.gonglei@huawei.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: crypto: virtio - Less function calls in __virtio_crypto_akcipher_do_req() after error detection
Date: Wed, 10 Jan 2024 08:46:21 +0100 [thread overview]
Message-ID: <0d7a06f0-7a0e-47c8-b89e-c3122b46d93e@web.de> (raw)
In-Reply-To: <20240109234241.4q3ueqdjz5o54oan@google.com>
>> The kfree() function was called in up to two cases by the
>> __virtio_crypto_akcipher_do_req() function during error handling
>> even if the passed variable contained a null pointer.
>> This issue was detected by using the Coccinelle software.
>
> If the script is short and simple would you mind, in the future,
> including it below the fold -- this may help others do similar work down
> the line -- Or …
Would you like to take another look at the clarification approach
“Reconsidering kfree() calls for null pointers (with SmPL)”?
https://lore.kernel.org/cocci/6cbcf640-55e5-2f11-4a09-716fe681c0d2@web.de/
https://sympa.inria.fr/sympa/arc/cocci/2023-03/msg00096.html
Regards,
Markus
next prev parent reply other threads:[~2024-01-10 7:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2413f22f-f0c3-45e0-9f6b-a551bdf0f54c@web.de>
2023-12-26 0:54 ` [PATCH] crypto: virtio - Less function calls in __virtio_crypto_akcipher_do_req() after error detection kernel test robot
2023-12-26 10:12 ` [PATCH v2] " Markus Elfring
2023-12-26 12:22 ` Gonglei (Arei)
2024-01-09 23:42 ` Justin Stitt
2024-01-10 7:46 ` Markus Elfring [this message]
2024-01-26 8:55 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d7a06f0-7a0e-47c8-b89e-c3122b46d93e@web.de \
--to=markus.elfring@web.de \
--cc=arei.gonglei@huawei.com \
--cc=cocci@inria.fr \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jasowang@redhat.com \
--cc=justinstitt@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).