From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EBEA651 for ; Sat, 23 Sep 2023 04:23:12 +0000 (UTC) Received: from eig-obgw-6006a.ext.cloudfilter.net ([10.0.30.182]) by cmsmtp with ESMTP id jnFoqIQC6QFHRju9AqtY6l; Sat, 23 Sep 2023 04:21:36 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id ju99q6cOk3FgHju99qQgg2; Sat, 23 Sep 2023 04:21:35 +0000 X-Authority-Analysis: v=2.4 cv=F4tEy4tN c=1 sm=1 tr=0 ts=650e67cf a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=P7XfKmiOJ4/qXqHZrN7ymg==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=zNV7Rl7Rt7sA:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=8AirrxEcAAAA:8 a=J1Y8HTJGAAAA:8 a=1XWaLZrsAAAA:8 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=cm27Pg_UAAAA:8 a=wH_VP6JpHQxiM5NuicYA:9 a=QEXdDO2ut3YA:10 a=ST-jHhOKWsTCqRlWije3:22 a=y1Q9-5lHfBjTkpIzbSAN:22 a=AjGcO6oz07-iQ99wixmX:22 a=xmb-EsYY8bH0VWELuYED:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BsB5eh7LJkdUqJDH0aHhFJiVNknPSJ6bHpixTUIHxFQ=; b=oiZEodhayEs4mgU7VZPLPKbZIY HWTjp7nDXHgslD9P4QY66qtDLeBX7lDvNH7QtChqI3Aw0Boz6CZbGes4kXpJz80fJ47YnqDZo+7+t OoRumCtCjklJapTLqndkKVNWE0+gTyYj2xQSS7K2tD/SffdUBXKc/nzdORQHwIjv8SF9BC8oCTLZb lKlqY7s0j6+Jz4pjQGU6kVw/KoA7fnhWDFsornszgnxWfolf8QDCJrLaj+MjcWAFZw6NcN79BBYtE tuSeG9qWTr2i2hkuFlKnHHYW8iWVbMSUGmV9ZrDN9QHM/xFO59cJTURPpb594PVPtveocziaWQupy u+/PD8fg==; Received: from [94.239.20.48] (port=42928 helo=[192.168.1.98]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1qjkJU-0000v7-0V; Fri, 22 Sep 2023 12:51:36 -0500 Message-ID: <0ff5fb14-1579-b3e2-c18d-d383d25da68a@embeddedor.com> Date: Fri, 22 Sep 2023 19:52:17 -0600 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 05/14] net: enetc: Annotate struct enetc_int_vector with __counted_by Content-Language: en-US To: Kees Cook , Jakub Kicinski Cc: Claudiu Manoil , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, Jamal Hadi Salim , David Ahern , Martin KaFai Lau , "Gustavo A. R. Silva" , Alexei Starovoitov , Yisen Zhuang , Salil Mehta , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Ajay Sharma , Alex Elder , Pravin B Shelar , Shaokun Zhang , Cong Wang , Jiri Pirko , Nathan Chancellor , Nick Desaulniers , Tom Rix , Simon Horman , linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-rdma@vger.kernel.org, dev@openvswitch.org, linux-parisc@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org References: <20230922172449.work.906-kees@kernel.org> <20230922172858.3822653-5-keescook@chromium.org> From: "Gustavo A. R. Silva" In-Reply-To: <20230922172858.3822653-5-keescook@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - lists.linux.dev X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 94.239.20.48 X-Source-L: No X-Exim-ID: 1qjkJU-0000v7-0V X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.98]) [94.239.20.48]:42928 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 0 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfB+2XAspGJiN3QFSpV7kegbutQM/noMYiOlI4tFcH02uKaj6Z807NRFA+gcLfxRjhIwlfJPphzOXVyz+iZ9bUGI7y6zDFjBqxLtjP9Gw0l1l5zchWWUj 6B+DO3pzHzU78eHAZIsjr1zvit1pzDz9jbSpjjo/A6DEAYxmamdu4t9qq4Y1frhgjISFAKKLlyEoloURHkGTGGzCs3spKPbrzF4= On 9/22/23 11:28, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct enetc_int_vector. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Claudiu Manoil > Cc: Vladimir Oltean > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/net/ethernet/freescale/enetc/enetc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/freescale/enetc/enetc.h b/drivers/net/ethernet/freescale/enetc/enetc.h > index 7439739cd81a..a9c2ff22431c 100644 > --- a/drivers/net/ethernet/freescale/enetc/enetc.h > +++ b/drivers/net/ethernet/freescale/enetc/enetc.h > @@ -297,7 +297,7 @@ struct enetc_int_vector { > char name[ENETC_INT_NAME_MAX]; > > struct enetc_bdr rx_ring; > - struct enetc_bdr tx_ring[]; > + struct enetc_bdr tx_ring[] __counted_by(count_tx_rings); > } ____cacheline_aligned_in_smp; > > struct enetc_cls_rule {