From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Justin Stitt <justinstitt@google.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"llvm@lists.linux.dev" <llvm@lists.linux.dev>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
"michael.christie@oracle.com" <michael.christie@oracle.com>,
"mingzhe.zou@easystack.cn" <mingzhe.zou@easystack.cn>,
"nathan@kernel.org" <nathan@kernel.org>,
"ndesaulniers@google.com" <ndesaulniers@google.com>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"trix@redhat.com" <trix@redhat.com>
Subject: Re: [PATCH v2] target: iscsi: fix clang -Wformat warnings
Date: Mon, 18 Jul 2022 21:35:27 +0000 [thread overview]
Message-ID: <161f9440-0b75-cd11-d9b5-5315721e44f4@nvidia.com> (raw)
In-Reply-To: <20220718180421.49697-1-justinstitt@google.com>
On 7/18/22 11:04, Justin Stitt wrote:
> When building with Clang we encounter these warnings:
> | drivers/target/iscsi/iscsi_target_login.c:719:24: error: format
> | specifies type 'unsigned short' but the argument has type 'int'
> | [-Werror,-Wformat] " from node: %s\n", atomic_read(&sess->nconn),
> -
> | drivers/target/iscsi/iscsi_target_login.c:767:12: error: format
> | specifies type 'unsigned short' but the argument has type 'int'
> | [-Werror,-Wformat] " %s\n", atomic_read(&sess->nconn),
> -
> | drivers/target/iscsi/iscsi_target.c:4365:12: error: format specifies
> | type 'unsigned short' but the argument has type 'int' [-Werror,-Wformat]
> | " %s\n", atomic_read(&sess->nconn)
>
> For all warnings, the format specifier is `%hu` which describes an
> unsigned short. The resulting type of atomic_read is an int. The
> proposed fix is to listen to Clang and swap the format specifier.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/378
> Signed-off-by: Justin Stitt <justinstitt@google.com>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2022-07-18 21:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 21:14 [PATCH] target: iscsi: fix clang -Wformat warning Justin Stitt
2022-07-08 23:42 ` Nick Desaulniers
2022-07-18 18:04 ` [PATCH v2] target: iscsi: fix clang -Wformat warnings Justin Stitt
2022-07-18 20:55 ` Nick Desaulniers
2022-07-18 21:35 ` Chaitanya Kulkarni [this message]
2022-07-19 3:00 ` Martin K. Petersen
2022-07-27 3:15 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161f9440-0b75-cd11-d9b5-5315721e44f4@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.petersen@oracle.com \
--cc=mgurtovoy@nvidia.com \
--cc=michael.christie@oracle.com \
--cc=mingzhe.zou@easystack.cn \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=target-devel@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox