Re: [PATCH] net: l2tp: fix clang -Wformat warning

patchwork-bot+netdevbpf
2022-07-08T01:30:13Z

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 6 Jul 2022 16:08:33 -0700 you wrote:
> When building with clang we encounter this warning:
> | net/l2tp/l2tp_ppp.c:1557:6: error: format specifies type 'unsigned
> | short' but the argument has type 'u32' (aka 'unsigned int')
> | [-Werror,-Wformat] session->nr, session->ns,
>
> Both session->nr and session->ns are of type u32. The format specifier
> previously used is `%hu` which would truncate our unsigned integer from
> 32 to 16 bits. This doesn't seem like intended behavior, if it is then
> perhaps we need to consider suppressing the warning with pragma clauses.
>
> [...]

Here is the summary with links:
- net: l2tp: fix clang -Wformat warning
https://git.kernel.org/netdev/net-next/c/a2b6111b55f3

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.