From: patchwork-bot+chrome-platform@kernel.org
To: Tom Rix <trix@redhat.com>
Cc: bleung@chromium.org, groeck@chromium.org, nathan@kernel.org,
ndesaulniers@google.com, chrome-platform@lists.linux.dev,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] platform/chrome: cros_ec_lpc: initialize the buf variable
Date: Fri, 13 Jan 2023 21:20:56 +0000 [thread overview]
Message-ID: <167364485633.21086.16143246139018637708.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230110193611.3573777-1-trix@redhat.com>
Hello:
This patch was applied to chrome-platform/linux.git (for-next)
by Tzung-Bi Shih <tzungbi@kernel.org>:
On Tue, 10 Jan 2023 14:36:11 -0500 you wrote:
> Clang static analysis reports this problem
> drivers/platform/chrome/cros_ec_lpc.c:379:13: warning: The left operand
> of '!=' is a garbage value [core.UndefinedBinaryOperatorResult]
> if (buf[0] != 'E' || buf[1] != 'C') {
> ~~~~~~ ^
>
> The check depends on the side effect of the read. When the read fails
> or is short, a buf containing garbage could be mistaken as correct.
>
> [...]
Here is the summary with links:
- platform/chrome: cros_ec_lpc: initialize the buf variable
https://git.kernel.org/chrome-platform/c/2ae3c610e7d2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-01-13 21:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 19:36 [PATCH] platform/chrome: cros_ec_lpc: initialize the buf variable Tom Rix
2023-01-11 3:30 ` patchwork-bot+chrome-platform
2023-01-13 21:20 ` patchwork-bot+chrome-platform [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167364485633.21086.16143246139018637708.git-patchwork-notify@kernel.org \
--to=patchwork-bot+chrome-platform@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox