Building the Linux kernel with Clang and LLVM
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Simon Horman <horms@kernel.org>
Cc: loic.poulain@linaro.org, ryazanov.s.a@gmail.com,
	johannes@sipsolutions.net, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, nathan@kernel.org, ndesaulniers@google.com,
	morbo@google.com, justinstitt@google.com, netdev@vger.kernel.org,
	llvm@lists.linux.dev
Subject: Re: [PATCH net-next] wwan: core: Pass string literal as format argument of dev_set_name()
Date: Tue, 29 Oct 2024 18:50:45 +0000	[thread overview]
Message-ID: <173022784550.787364.9831173645509301356.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20241023-wwan-fmt-v1-1-521b39968639@kernel.org>

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 23 Oct 2024 13:15:28 +0100 you wrote:
> Both gcc-14 and clang-18 report that passing a non-string literal as the
> format argument of dev_set_name() is potentially insecure.
> 
> E.g. clang-18 says:
> 
> drivers/net/wwan/wwan_core.c:442:34: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
>   442 |         return dev_set_name(&port->dev, buf);
>       |                                         ^~~
> drivers/net/wwan/wwan_core.c:442:34: note: treat the string as an argument to avoid this
>   442 |         return dev_set_name(&port->dev, buf);
>       |                                         ^
>       |                                         "%s",
> 
> [...]

Here is the summary with links:
  - [net-next] wwan: core: Pass string literal as format argument of dev_set_name()
    https://git.kernel.org/netdev/net-next/c/3f7f3ef44f4b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2024-10-29 18:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23 12:15 [PATCH net-next] wwan: core: Pass string literal as format argument of dev_set_name() Simon Horman
2024-10-29  0:22 ` Sergey Ryazanov
2024-10-29 18:50 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173022784550.787364.9831173645509301356.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=justinstitt@google.com \
    --cc=kuba@kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=loic.poulain@linaro.org \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ryazanov.s.a@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox