Re: [Intel-gfx] [RFC 3/5] drm/i915/panelreplay: Initializaton and compute config for panel replay

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3883 bytes --]

Hi Animesh,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next linus/master v5.14 next-20210908]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Animesh-Manna/Panel-replay-phase1-implementation/20210908-174047
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: i386-randconfig-a014-20210908 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 9c476172b93367d2cb88d7d3f4b1b5b456fa6020)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/bf8dbe6cdf67f84e31710ceda7384ed0a7af1462
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Animesh-Manna/Panel-replay-phase1-implementation/20210908-174047
        git checkout bf8dbe6cdf67f84e31710ceda7384ed0a7af1462
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/i915/display/intel_dp.c:2752:27: error: overlapping comparisons always evaluate to true [-Werror,-Wtautological-overlap-compare]
           if (vsc->revision != 0x5 || vsc->revision != 0x7)
               ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.


vim +2752 drivers/gpu/drm/i915/display/intel_dp.c

  2728	
  2729	static ssize_t intel_dp_vsc_sdp_pack(const struct drm_dp_vsc_sdp *vsc,
  2730					     struct dp_sdp *sdp, size_t size)
  2731	{
  2732		size_t length = sizeof(struct dp_sdp);
  2733	
  2734		if (size < length)
  2735			return -ENOSPC;
  2736	
  2737		memset(sdp, 0, size);
  2738	
  2739		/*
  2740		 * Prepare VSC Header for SU as per DP 1.4a spec, Table 2-119
  2741		 * VSC SDP Header Bytes
  2742		 */
  2743		sdp->sdp_header.HB0 = 0; /* Secondary-Data Packet ID = 0 */
  2744		sdp->sdp_header.HB1 = vsc->sdp_type; /* Secondary-data Packet Type */
  2745		sdp->sdp_header.HB2 = vsc->revision; /* Revision Number */
  2746		sdp->sdp_header.HB3 = vsc->length; /* Number of Valid Data Bytes */
  2747	
  2748		/*
  2749		 * Revision 0x5 and 0x7 supports Pixel Encoding/Colorimetry Format as
  2750		 * per DP 1.4a spec and DP 2.0 spec respectively.
  2751		 */
> 2752		if (vsc->revision != 0x5 || vsc->revision != 0x7)
  2753			goto out;
  2754	
  2755		/* VSC SDP Payload for DB16 through DB18 */
  2756		/* Pixel Encoding and Colorimetry Formats  */
  2757		sdp->db[16] = (vsc->pixelformat & 0xf) << 4; /* DB16[7:4] */
  2758		sdp->db[16] |= vsc->colorimetry & 0xf; /* DB16[3:0] */
  2759	
  2760		switch (vsc->bpc) {
  2761		case 6:
  2762			/* 6bpc: 0x0 */
  2763			break;
  2764		case 8:
  2765			sdp->db[17] = 0x1; /* DB17[3:0] */
  2766			break;
  2767		case 10:
  2768			sdp->db[17] = 0x2;
  2769			break;
  2770		case 12:
  2771			sdp->db[17] = 0x3;
  2772			break;
  2773		case 16:
  2774			sdp->db[17] = 0x4;
  2775			break;
  2776		default:
  2777			MISSING_CASE(vsc->bpc);
  2778			break;
  2779		}
  2780		/* Dynamic Range and Component Bit Depth */
  2781		if (vsc->dynamic_range == DP_DYNAMIC_RANGE_CTA)
  2782			sdp->db[17] |= 0x80;  /* DB17[7] */
  2783	
  2784		/* Content Type */
  2785		sdp->db[18] = vsc->content_type & 0x7;
  2786	
  2787	out:
  2788		return length;
  2789	}
  2790	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33820 bytes --]