From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 623AD3FD0 for ; Mon, 13 Sep 2021 16:26:40 +0000 (UTC) Received: by mail-pf1-f181.google.com with SMTP id y8so3972245pfa.7 for ; Mon, 13 Sep 2021 09:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vVZh4MCHii9RTsWAwJzzvhkJJB7eqF9Wlqiwcsfsd5A=; b=IFp6db6z5flQv5KvwMeluytmMACinEebhmMpTUIvac32Z2JVxbTPQElYhGgALDg2GH Lkyro0kcU9vQmc/s1mgXQZU/1pOWZ0POFRqIC/5xcPBREfVB++dHkiZGLl6OVbPZu+bt wqTVSigmTQyd66yVwVX+b0+p+G2mDUsvC1O/k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vVZh4MCHii9RTsWAwJzzvhkJJB7eqF9Wlqiwcsfsd5A=; b=nxwEiwim0bDdLRVYF5DEqHwY3aNx/kOHugKlSrW/vQ7sptqb0wkiC/6J8Gv/Of2U2j QAMZEdmsAN0Px+gJH9m2Vt9dItpjSEQ65YrY38LCbAlnyFkYCYXc7Z9wORAwsNkUgTFW EaGnoD0HTL/Ai+5WbwdRMvn8EyNFOMKBuMq/U3/CsjWJ5TUPqi/AYV12NJwnmteLJp7x eYyuNhDxaZ0ibAYKT9w8encFA3mrNbvdFlFWH0ZBGxSYpSHrEqXs+5Ypl8oE3rIUdOg3 ZY90ccI7o967hxt0l5f/SaX3yB2T1CiEj/iEWeAYg1Qk9T/qMeyUMsJUgtNYd6OgacEL 42ow== X-Gm-Message-State: AOAM5313TJYbNEGlmAKOAnRPFrZBC6WCQSRtd0mxr4ObnsSN4GIanRNP Uxq/eXqxgci4acANOZl91kOGng== X-Google-Smtp-Source: ABdhPJx7XgLpvkSC/flgyeNbQbpq/4yeHX7epVqvfa/MPqlXRRH27EKSgqYBMgToUxDQoNJsUTBKNQ== X-Received: by 2002:aa7:85d8:0:b0:408:78f4:a5fe with SMTP id z24-20020aa785d8000000b0040878f4a5femr397784pfn.2.1631550399978; Mon, 13 Sep 2021 09:26:39 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u10sm7423363pjf.46.2021.09.13.09.26.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Sep 2021 09:26:39 -0700 (PDT) Date: Mon, 13 Sep 2021 09:26:38 -0700 From: Kees Cook To: Nick Desaulniers Cc: Andrew Morton , Linus Torvalds , Rasmus Villemoes , Nathan Chancellor , Masahiro Yamada , Joe Perches , Arnd Bergmann , Stephen Rothwell , llvm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/10] compiler-gcc.h: drop checks for older GCC versions Message-ID: <202109130926.15C4D3486F@keescook> References: <20210910234047.1019925-1-ndesaulniers@google.com> <20210910234047.1019925-10-ndesaulniers@google.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210910234047.1019925-10-ndesaulniers@google.com> On Fri, Sep 10, 2021 at 04:40:46PM -0700, Nick Desaulniers wrote: > Now that GCC 5.1 is the minimally supported default, drop the values we > don't use. > > Signed-off-by: Nick Desaulniers > --- > include/linux/compiler-gcc.h | 4 +--- > tools/include/linux/compiler-gcc.h | 4 +--- > 2 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h > index 3f7f6fa0e051..fd82ce169ce9 100644 > --- a/include/linux/compiler-gcc.h > +++ b/include/linux/compiler-gcc.h > @@ -98,10 +98,8 @@ > > #if GCC_VERSION >= 70000 > #define KASAN_ABI_VERSION 5 > -#elif GCC_VERSION >= 50000 > +#else > #define KASAN_ABI_VERSION 4 > -#elif GCC_VERSION >= 40902 > -#define KASAN_ABI_VERSION 3 > #endif > > #if __has_attribute(__no_sanitize_address__) Reviewed-by: Kees Cook > diff --git a/tools/include/linux/compiler-gcc.h b/tools/include/linux/compiler-gcc.h > index a590a1dfafd9..43d9a46d36f0 100644 > --- a/tools/include/linux/compiler-gcc.h > +++ b/tools/include/linux/compiler-gcc.h > @@ -16,9 +16,7 @@ > # define __fallthrough __attribute__ ((fallthrough)) > #endif > > -#if GCC_VERSION >= 40300 > -# define __compiletime_error(message) __attribute__((error(message))) > -#endif /* GCC_VERSION >= 40300 */ > +#define __compiletime_error(message) __attribute__((error(message))) > > /* &a[0] degrades to a pointer: a different type from an array */ > #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0])) This part could be applied regardless (it's a missed 4.3 check, yes?) -- Kees Cook