From: Nathan Chancellor <nathan@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
llvm@lists.linux.dev, Nathan Chancellor <nathan@kernel.org>
Subject: [PATCH v2 0/2] Harden clang against unknown flag options
Date: Thu, 16 Sep 2021 11:40:15 -0700 [thread overview]
Message-ID: <20210916184017.1881473-1-nathan@kernel.org> (raw)
Hi all,
This series cleans up an issue that was noticed by the kernel test robot
where flags that clang does not implement support for are
unconditionally added to the command line, which causes all subsequent
calls to cc-{disable-warning,option} to fail, meaning developers are
flooded with unnecessary and pointless warnings.
The first patch handles the problematic flags with cc-option for clang
and the second patch ensures we catch new additions of unknown flags so
that they can be handled properly.
I intend for this to be merged via the kbuild tree but it can go via
-tip if there is any objection to that.
Cheers,
Nathan
v1 -> v2: https://lore.kernel.org/r/20210824022640.2170859-1-nathan@kernel.org/
* Patch 1: Change prefix to "x86/build" (Borislav).
* Patch 1: Add link to v1 thread for more context (Borislav).
* Patch 1: Add Borislav's ack.
* Patch 2: Expand comment in source to make it clear that clang only
warns on certain unimplemented optimization flags.
* Series: Add Nick's review.
Nathan Chancellor (2):
x86/build: Do not add -falign flags unconditionally for clang
kbuild: Add -Werror=ignored-optimization-argument to CLANG_FLAGS
arch/x86/Makefile_32.cpu | 12 +++++++++---
scripts/Makefile.clang | 5 +++++
2 files changed, 14 insertions(+), 3 deletions(-)
base-commit: a9086b878b7fd65894eb8cb1fa395dd469970566
--
2.33.0
next reply other threads:[~2021-09-16 18:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 18:40 Nathan Chancellor [this message]
2021-09-16 18:40 ` [PATCH v2 1/2] x86/build: Do not add -falign flags unconditionally for clang Nathan Chancellor
2021-09-19 2:01 ` Masahiro Yamada
2021-09-16 18:40 ` [PATCH v2 2/2] kbuild: Add -Werror=ignored-optimization-argument to CLANG_FLAGS Nathan Chancellor
2021-09-19 2:01 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210916184017.1881473-1-nathan@kernel.org \
--to=nathan@kernel.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=mingo@redhat.com \
--cc=ndesaulniers@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox