* Re: [RFC/PATCH net-next v2 2/5] flow_offload: allow user to offload tc action to net device
[not found] <20211001113237.14449-3-simon.horman@corigine.com>
@ 2021-10-01 18:26 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-10-01 18:26 UTC (permalink / raw)
To: Simon Horman; +Cc: llvm, kbuild-all
[-- Attachment #1: Type: text/plain, Size: 5365 bytes --]
Hi Simon,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Simon-Horman/allow-user-to-offload-tc-action-to-net-device/20211001-193504
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git b05173028cc52384be42dcf81abdb4133caccfa5
config: i386-randconfig-a016-20211001 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 962e503cc8bc411f7523cc393acae8aae425b1c4)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/9a454eedd446af072f867f4927802d3b42ed3406
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Simon-Horman/allow-user-to-offload-tc-action-to-net-device/20211001-193504
git checkout 9a454eedd446af072f867f4927802d3b42ed3406
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> net/sched/act_api.c:1171:13: warning: variable 'err' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
} else if (is_tcf_gate(act)) {
^~~~~~~~~~~~~~~~
net/sched/act_api.c:1179:9: note: uninitialized use occurs here
return err;
^~~
net/sched/act_api.c:1171:9: note: remove the 'if' if its condition is always true
} else if (is_tcf_gate(act)) {
^~~~~~~~~~~~~~~~~~~~~~
net/sched/act_api.c:1096:9: note: initialize the variable 'err' to silence this warning
int err;
^
= 0
1 warning generated.
vim +1171 net/sched/act_api.c
1090
1091 static int flow_action_init(struct flow_offload_action *fl_action,
1092 struct tc_action *act,
1093 enum flow_act_command cmd,
1094 struct netlink_ext_ack *extack)
1095 {
1096 int err;
1097
1098 if (!fl_action)
1099 return -EINVAL;
1100
1101 fl_action->extack = extack;
1102 fl_action->command = cmd;
1103 fl_action->index = act->tcfa_index;
1104
1105 if (is_tcf_gact_ok(act)) {
1106 fl_action->id = FLOW_ACTION_ACCEPT;
1107 } else if (is_tcf_gact_shot(act)) {
1108 fl_action->id = FLOW_ACTION_DROP;
1109 } else if (is_tcf_gact_trap(act)) {
1110 fl_action->id = FLOW_ACTION_TRAP;
1111 } else if (is_tcf_gact_goto_chain(act)) {
1112 fl_action->id = FLOW_ACTION_GOTO;
1113 } else if (is_tcf_mirred_egress_redirect(act)) {
1114 fl_action->id = FLOW_ACTION_REDIRECT;
1115 } else if (is_tcf_mirred_egress_mirror(act)) {
1116 fl_action->id = FLOW_ACTION_MIRRED;
1117 } else if (is_tcf_mirred_ingress_redirect(act)) {
1118 fl_action->id = FLOW_ACTION_REDIRECT_INGRESS;
1119 } else if (is_tcf_mirred_ingress_mirror(act)) {
1120 fl_action->id = FLOW_ACTION_MIRRED_INGRESS;
1121 } else if (is_tcf_vlan(act)) {
1122 switch (tcf_vlan_action(act)) {
1123 case TCA_VLAN_ACT_PUSH:
1124 fl_action->id = FLOW_ACTION_VLAN_PUSH;
1125 break;
1126 case TCA_VLAN_ACT_POP:
1127 fl_action->id = FLOW_ACTION_VLAN_POP;
1128 break;
1129 case TCA_VLAN_ACT_MODIFY:
1130 fl_action->id = FLOW_ACTION_VLAN_MANGLE;
1131 break;
1132 default:
1133 err = -EOPNOTSUPP;
1134 goto err_out;
1135 }
1136 } else if (is_tcf_tunnel_set(act)) {
1137 fl_action->id = FLOW_ACTION_TUNNEL_ENCAP;
1138 } else if (is_tcf_tunnel_release(act)) {
1139 fl_action->id = FLOW_ACTION_TUNNEL_DECAP;
1140 } else if (is_tcf_pedit(act)) {
1141 fl_action->id = FLOW_ACTION_PEDIT;
1142 } else if (is_tcf_csum(act)) {
1143 fl_action->id = FLOW_ACTION_CSUM;
1144 } else if (is_tcf_skbedit_mark(act)) {
1145 fl_action->id = FLOW_ACTION_MARK;
1146 } else if (is_tcf_sample(act)) {
1147 fl_action->id = FLOW_ACTION_SAMPLE;
1148 } else if (is_tcf_police(act)) {
1149 fl_action->id = FLOW_ACTION_POLICE;
1150 } else if (is_tcf_ct(act)) {
1151 fl_action->id = FLOW_ACTION_CT;
1152 } else if (is_tcf_mpls(act)) {
1153 switch (tcf_mpls_action(act)) {
1154 case TCA_MPLS_ACT_PUSH:
1155 fl_action->id = FLOW_ACTION_MPLS_PUSH;
1156 break;
1157 case TCA_MPLS_ACT_POP:
1158 fl_action->id = FLOW_ACTION_MPLS_POP;
1159 break;
1160 case TCA_MPLS_ACT_MODIFY:
1161 fl_action->id = FLOW_ACTION_MPLS_MANGLE;
1162 break;
1163 default:
1164 err = -EOPNOTSUPP;
1165 goto err_out;
1166 }
1167 } else if (is_tcf_skbedit_ptype(act)) {
1168 fl_action->id = FLOW_ACTION_PTYPE;
1169 } else if (is_tcf_skbedit_priority(act)) {
1170 fl_action->id = FLOW_ACTION_PRIORITY;
> 1171 } else if (is_tcf_gate(act)) {
1172 fl_action->id = FLOW_ACTION_GATE;
1173 } else {
1174 goto err_out;
1175 }
1176 return 0;
1177
1178 err_out:
1179 return err;
1180 }
1181
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36375 bytes --]
^ permalink raw reply [flat|nested] only message in thread