Re: [RFC net-next PATCH 07/16] net: phylink: Add helpers for c22 registers without MDIO

Re: [RFC net-next PATCH 07/16] net: phylink: Add helpers for c22 registers without MDIO

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 3456 bytes --]

Hi Sean,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Sean-Anderson/Add-support-for-Xilinx-PCS/20211005-035032
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git b05173028cc52384be42dcf81abdb4133caccfa5
config: hexagon-randconfig-r041-20211004 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c0039de2953d15815448b4b3c3bafb45607781e0)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/5513e28755a3b4bb2616959fd5e8533211a9ac3c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sean-Anderson/Add-support-for-Xilinx-PCS/20211005-035032
        git checkout 5513e28755a3b4bb2616959fd5e8533211a9ac3c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=hexagon 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/phy/phylink.c:2786:14: warning: variable 'adv' is uninitialized when used here [-Wuninitialized]
                                                          adv);
                                                          ^~~
   drivers/net/phy/phylink.c:2779:9: note: initialize the variable 'adv' to silence this warning
           u16 adv;
                  ^
                   = 0
   1 warning generated.


vim +/adv +2786 drivers/net/phy/phylink.c

  2754	
  2755	/**
  2756	 * phylink_mii_c22_pcs_set_advertisement() - configure the clause 37 PCS
  2757	 *	advertisement
  2758	 * @pcs: a pointer to a &struct mdio_device.
  2759	 * @interface: the PHY interface mode being configured
  2760	 * @advertising: the ethtool advertisement mask
  2761	 *
  2762	 * Helper for MAC PCS supporting the 802.3 clause 22 register set for
  2763	 * clause 37 negotiation and/or SGMII control.
  2764	 *
  2765	 * Configure the clause 37 PCS advertisement as specified by @state. This
  2766	 * does not trigger a renegotiation; phylink will do that via the
  2767	 * mac_an_restart() method of the struct phylink_mac_ops structure.
  2768	 *
  2769	 * Returns negative error code on failure to configure the advertisement,
  2770	 * zero if no change has been made, or one if the advertisement has changed.
  2771	 */
  2772	int phylink_mii_c22_pcs_set_advertisement(struct mdio_device *pcs,
  2773						  phy_interface_t interface,
  2774						  const unsigned long *advertising)
  2775	{
  2776		struct mii_bus *bus = pcs->bus;
  2777		int addr = pcs->addr;
  2778		int val, ret;
  2779		u16 adv;
  2780	
  2781		val = mdiobus_read(bus, addr, MII_ADVERTISE);
  2782		if (val < 0)
  2783			return val;
  2784	
  2785		adv = phylink_mii_c22_pcs_encode_advertisement(interface, advertising,
> 2786							       adv);
  2787		if (adv == val)
  2788			return 0;
  2789	
  2790		ret = mdiobus_write(bus, addr, MII_ADVERTISE, adv);
  2791		return ret < 0 ? ret : 1;
  2792	}
  2793	EXPORT_SYMBOL_GPL(phylink_mii_c22_pcs_set_advertisement);
  2794	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33301 bytes --]