* Re: [PATCH v4 06/10] hwmon: (tmp421) really disable channels
[not found] <eaee0947c813b04b77ee8364724d1a406dccc33b.1634029538.git.krzysztof.adamski@nokia.com>
@ 2021-10-12 18:01 ` kernel test robot
2021-10-13 18:50 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-10-12 18:01 UTC (permalink / raw)
To: Krzysztof Adamski, Guenter Roeck, Jean Delvare
Cc: llvm, kbuild-all, Rob Herring, linux-hwmon, devicetree
[-- Attachment #1: Type: text/plain, Size: 3028 bytes --]
Hi Krzysztof,
I love your patch! Perhaps something to improve:
[auto build test WARNING on groeck-staging/hwmon-next]
[also build test WARNING on next-20211012]
[cannot apply to robh/for-next v5.15-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Krzysztof-Adamski/Add-per-channel-properies-support-in-tmp421/20211012-173142
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: arm64-randconfig-r024-20211012 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c3dcf39554dbea780d6cb7e12239451ba47a2668)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/4a0f8262fe071b0b27c6fba7455627f3c5a5209e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Krzysztof-Adamski/Add-per-channel-properies-support-in-tmp421/20211012-173142
git checkout 4a0f8262fe071b0b27c6fba7455627f3c5a5209e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/hwmon/tmp421.c:178:10: warning: variable 'err' is uninitialized when used here [-Wuninitialized]
return err;
^~~
drivers/hwmon/tmp421.c:170:9: note: initialize the variable 'err' to silence this warning
int err;
^
= 0
1 warning generated.
vim +/err +178 drivers/hwmon/tmp421.c
167
168 static int tmp421_enable_channels(struct tmp421_data *data)
169 {
170 int err;
171 struct i2c_client *client = data->client;
172 struct device *dev = &client->dev;
173 int cfg = i2c_smbus_read_byte_data(client, TMP421_CONFIG_REG_2);
174 int i;
175
176 if (cfg < 0) {
177 dev_err(dev, "error reading register, can't disable channels\n");
> 178 return err;
179 }
180
181 cfg &= ~TMP421_CONFIG_REG_REN_MASK;
182 for (i = 0; i < data->channels; i++)
183 if (data->channel[i].enabled)
184 cfg |= TMP421_CONFIG_REG_REN(i);
185
186 err = i2c_smbus_write_byte_data(client, TMP421_CONFIG_REG_2, cfg);
187 if (err < 0)
188 dev_err(dev, "error writing register, can't disable channels\n");
189
190 return err;
191 }
192
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 45131 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4 06/10] hwmon: (tmp421) really disable channels
[not found] <eaee0947c813b04b77ee8364724d1a406dccc33b.1634029538.git.krzysztof.adamski@nokia.com>
2021-10-12 18:01 ` [PATCH v4 06/10] hwmon: (tmp421) really disable channels kernel test robot
@ 2021-10-13 18:50 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-10-13 18:50 UTC (permalink / raw)
To: Krzysztof Adamski, Guenter Roeck, Jean Delvare
Cc: llvm, kbuild-all, Rob Herring, linux-hwmon, devicetree
[-- Attachment #1: Type: text/plain, Size: 2916 bytes --]
Hi Krzysztof,
I love your patch! Yet something to improve:
[auto build test ERROR on groeck-staging/hwmon-next]
[also build test ERROR on next-20211013]
[cannot apply to robh/for-next v5.15-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Krzysztof-Adamski/Add-per-channel-properies-support-in-tmp421/20211012-173142
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: i386-buildonly-randconfig-r004-20211013 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a8c695542b2987eb9a203d5663a0740cb4725f)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4a0f8262fe071b0b27c6fba7455627f3c5a5209e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Krzysztof-Adamski/Add-per-channel-properies-support-in-tmp421/20211012-173142
git checkout 4a0f8262fe071b0b27c6fba7455627f3c5a5209e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/hwmon/tmp421.c:178:10: error: variable 'err' is uninitialized when used here [-Werror,-Wuninitialized]
return err;
^~~
drivers/hwmon/tmp421.c:170:9: note: initialize the variable 'err' to silence this warning
int err;
^
= 0
1 error generated.
vim +/err +178 drivers/hwmon/tmp421.c
167
168 static int tmp421_enable_channels(struct tmp421_data *data)
169 {
170 int err;
171 struct i2c_client *client = data->client;
172 struct device *dev = &client->dev;
173 int cfg = i2c_smbus_read_byte_data(client, TMP421_CONFIG_REG_2);
174 int i;
175
176 if (cfg < 0) {
177 dev_err(dev, "error reading register, can't disable channels\n");
> 178 return err;
179 }
180
181 cfg &= ~TMP421_CONFIG_REG_REN_MASK;
182 for (i = 0; i < data->channels; i++)
183 if (data->channel[i].enabled)
184 cfg |= TMP421_CONFIG_REG_REN(i);
185
186 err = i2c_smbus_write_byte_data(client, TMP421_CONFIG_REG_2, cfg);
187 if (err < 0)
188 dev_err(dev, "error writing register, can't disable channels\n");
189
190 return err;
191 }
192
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 40883 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4 06/10] hwmon: (tmp421) really disable channels
[not found] <202111160852.wAsQBtqC-lkp@intel.com>
@ 2021-11-16 9:09 ` kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-11-16 9:09 UTC (permalink / raw)
To: Krzysztof Adamski; +Cc: llvm, kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3995 bytes --]
Hi Krzysztof,
Thanks for your patch! Perhaps something to improve:
[auto build test WARNING on groeck-staging/hwmon-next]
[cannot apply to robh/for-next v5.16-rc1 next-20211115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Krzysztof-Adamski/Add-per-channel-properies-support-in-tmp421/20211012-173142
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: arm-randconfig-c002-20211013 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a8c695542b2987eb9a203d5663a0740cb4725f)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/0day-ci/linux/commit/4a0f8262fe071b0b27c6fba7455627f3c5a5209e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Krzysztof-Adamski/Add-per-channel-properies-support-in-tmp421/20211012-173142
git checkout 4a0f8262fe071b0b27c6fba7455627f3c5a5209e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm clang-analyzer
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
clang-analyzer warnings: (new ones prefixed by >>)
>> drivers/hwmon/tmp421.c:178:3: warning: Undefined or garbage value returned to caller [clang-analyzer-core.uninitialized.UndefReturn]
return err;
^
vim +178 drivers/hwmon/tmp421.c
9410700b881f867 Andre Prendel 2009-09-15 167
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 168 static int tmp421_enable_channels(struct tmp421_data *data)
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 169 {
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 170 int err;
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 171 struct i2c_client *client = data->client;
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 172 struct device *dev = &client->dev;
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 173 int cfg = i2c_smbus_read_byte_data(client, TMP421_CONFIG_REG_2);
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 174 int i;
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 175
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 176 if (cfg < 0) {
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 177 dev_err(dev, "error reading register, can't disable channels\n");
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 @178 return err;
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 179 }
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 180
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 181 cfg &= ~TMP421_CONFIG_REG_REN_MASK;
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 182 for (i = 0; i < data->channels; i++)
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 183 if (data->channel[i].enabled)
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 184 cfg |= TMP421_CONFIG_REG_REN(i);
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 185
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 186 err = i2c_smbus_write_byte_data(client, TMP421_CONFIG_REG_2, cfg);
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 187 if (err < 0)
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 188 dev_err(dev, "error writing register, can't disable channels\n");
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 189
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 190 return err;
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 191 }
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 192
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34094 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-16 9:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <eaee0947c813b04b77ee8364724d1a406dccc33b.1634029538.git.krzysztof.adamski@nokia.com>
2021-10-12 18:01 ` [PATCH v4 06/10] hwmon: (tmp421) really disable channels kernel test robot
2021-10-13 18:50 ` kernel test robot
[not found] <202111160852.wAsQBtqC-lkp@intel.com>
2021-11-16 9:09 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox