Re: [PATCH 3/3] bpf: Implement prealloc for task_local_storage

Re: [PATCH 3/3] bpf: Implement prealloc for task_local_storage

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 3278 bytes --]

Hi Tejun,

I love your patch! Yet something to improve:

[auto build test ERROR on tj-cgroup/for-next]
[also build test ERROR on bpf-next/master bpf/master v5.15-rc6 next-20211021]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Tejun-Heo/cgroup-Drop-cgroup_-prefix-from-cgroup_threadgroup_rwsem-and-friends/20211021-051806
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next
config: arm-randconfig-c002-20211021 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 3cea2505fd8d99a9ba0cb625aecfe28a47c4e3f8)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/fc6c3a4ef8dde2e304e1b4eee47b7195638c1224
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Tejun-Heo/cgroup-Drop-cgroup_-prefix-from-cgroup_threadgroup_rwsem-and-friends/20211021-051806
        git checkout fc6c3a4ef8dde2e304e1b4eee47b7195638c1224
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> kernel/bpf/bpf_task_storage.c:371:20: error: use of undeclared identifier 'task_storage_map_ops'
                   smap->map.ops = &task_storage_map_ops;
                                    ^
   1 error generated.


vim +/task_storage_map_ops +371 kernel/bpf/bpf_task_storage.c

   355	
   356	static struct bpf_map *task_storage_map_alloc(union bpf_attr *attr)
   357	{
   358		struct bpf_local_storage_map *smap;
   359		int err;
   360	
   361		smap = bpf_local_storage_map_alloc(attr);
   362		if (IS_ERR(smap))
   363			return ERR_CAST(smap);
   364	
   365		if (!(attr->map_flags & BPF_F_NO_PREALLOC)) {
   366			/* We're going to exercise the regular update path to populate
   367			 * the map for the existing tasks, which will call into map ops
   368			 * which is normally initialized after this function returns.
   369			 * Initialize it early here.
   370			 */
 > 371			smap->map.ops = &task_storage_map_ops;
   372	
   373			percpu_down_write(&threadgroup_rwsem);
   374			list_add_tail(&smap->prealloc_node, &prealloc_smaps);
   375			err = task_storage_map_populate(smap);
   376			percpu_up_write(&threadgroup_rwsem);
   377			if (err) {
   378				bpf_local_storage_map_free(smap,
   379							   &bpf_task_storage_busy);
   380				return ERR_PTR(err);
   381			}
   382		}
   383	
   384		smap->cache_idx = bpf_local_storage_cache_idx_get(&task_cache);
   385		return &smap->map;
   386	}
   387	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30158 bytes --]