Re: [PATCH] ASoC: Intel: Unify HDAudio-ext bus initialization

Re: [PATCH] ASoC: Intel: Unify HDAudio-ext bus initialization

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 4049 bytes --]

Hi Cezary,

I love your patch! Perhaps something to improve:

[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on tiwai-sound/for-next v5.15-rc6 next-20211022]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Cezary-Rojewski/ASoC-Intel-Unify-HDAudio-ext-bus-initialization/20211019-032047
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: x86_64-randconfig-a012-20211022 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 5dc339d9825f1dbe788cfb69c88210a59bbf8e3a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/997e684694fcfc54bfef7a1c21e1788bc52a29af
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Cezary-Rojewski/ASoC-Intel-Unify-HDAudio-ext-bus-initialization/20211019-032047
        git checkout 997e684694fcfc54bfef7a1c21e1788bc52a29af
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> sound/soc/intel/skylake/skl.c:864:19: warning: variable 'bus' set but not used [-Wunused-but-set-variable]
           struct hdac_bus *bus;
                            ^
   1 warning generated.


vim +/bus +864 sound/soc/intel/skylake/skl.c

ab1b732d53c18f Vinod Koul         2017-05-04  855  
d8c2dab8381d58 Jeeja KP           2015-07-09  856  /*
d8c2dab8381d58 Jeeja KP           2015-07-09  857   * constructor
d8c2dab8381d58 Jeeja KP           2015-07-09  858   */
d8c2dab8381d58 Jeeja KP           2015-07-09  859  static int skl_create(struct pci_dev *pci,
bcc2a2dc3ba8c3 Cezary Rojewski    2019-07-23  860  		      struct skl_dev **rskl)
d8c2dab8381d58 Jeeja KP           2015-07-09  861  {
6bae5ea9498926 Rakesh Ughreja     2018-08-22  862  	struct hdac_ext_bus_ops *ext_ops = NULL;
bcc2a2dc3ba8c3 Cezary Rojewski    2019-07-23  863  	struct skl_dev *skl;
76f56fae1cf904 Rakesh Ughreja     2018-06-01 @864  	struct hdac_bus *bus;
00deadb5d86a3c Rakesh Ughreja     2018-08-22  865  	struct hda_bus *hbus;
d8c2dab8381d58 Jeeja KP           2015-07-09  866  	int err;
d8c2dab8381d58 Jeeja KP           2015-07-09  867  
d8c2dab8381d58 Jeeja KP           2015-07-09  868  	*rskl = NULL;
d8c2dab8381d58 Jeeja KP           2015-07-09  869  
d8c2dab8381d58 Jeeja KP           2015-07-09  870  	err = pci_enable_device(pci);
d8c2dab8381d58 Jeeja KP           2015-07-09  871  	if (err < 0)
d8c2dab8381d58 Jeeja KP           2015-07-09  872  		return err;
d8c2dab8381d58 Jeeja KP           2015-07-09  873  
d8c2dab8381d58 Jeeja KP           2015-07-09  874  	skl = devm_kzalloc(&pci->dev, sizeof(*skl), GFP_KERNEL);
d8c2dab8381d58 Jeeja KP           2015-07-09  875  	if (!skl) {
d8c2dab8381d58 Jeeja KP           2015-07-09  876  		pci_disable_device(pci);
d8c2dab8381d58 Jeeja KP           2015-07-09  877  		return -ENOMEM;
d8c2dab8381d58 Jeeja KP           2015-07-09  878  	}
76f56fae1cf904 Rakesh Ughreja     2018-06-01  879  
00deadb5d86a3c Rakesh Ughreja     2018-08-22  880  	hbus = skl_to_hbus(skl);
76f56fae1cf904 Rakesh Ughreja     2018-06-01  881  	bus = skl_to_bus(skl);
6bae5ea9498926 Rakesh Ughreja     2018-08-22  882  
776cb3b80ede9e Amadeusz Sławiński 2019-06-17  883  	INIT_LIST_HEAD(&skl->ppl_list);
776cb3b80ede9e Amadeusz Sławiński 2019-06-17  884  	INIT_LIST_HEAD(&skl->bind_list);
776cb3b80ede9e Amadeusz Sławiński 2019-06-17  885  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35732 bytes --]