Re: [PATCH v4 3/4] ACPI: APEI: Reserve the MCFG address for quirk ECAM implementation

Re: [PATCH v4 3/4] ACPI: APEI: Reserve the MCFG address for quirk ECAM implementation

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 4642 bytes --]

Hi Xuesong,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on helgaas-pci/next]
[also build test WARNING on rafael-pm/linux-next tip/x86/core arm64/for-next/core v5.15-rc7 next-20211027]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Xuesong-Chen/PCI-MCFG-Consolidate-the-separate-PCI-MCFG-table-entry-list/20211027-171229
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: x86_64-randconfig-a002-20211027 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 5db7568a6a1fcb408eb8988abdaff2a225a8eb72)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8fce66d9da6f8e55c5cf0dda4a13dba6bd51492d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Xuesong-Chen/PCI-MCFG-Consolidate-the-separate-PCI-MCFG-table-entry-list/20211027-171229
        git checkout 8fce66d9da6f8e55c5cf0dda4a13dba6bd51492d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/acpi/apei/apei-base.c:453:5: warning: no previous prototype for function 'remove_quirk_mcfg_res' [-Wmissing-prototypes]
   int remove_quirk_mcfg_res(struct apei_resources *mcfg_res)
       ^
   drivers/acpi/apei/apei-base.c:453:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int remove_quirk_mcfg_res(struct apei_resources *mcfg_res)
   ^
   static 
   drivers/acpi/apei/apei-base.c:804:12: warning: no previous prototype for function 'arch_apei_enable_cmcff' [-Wmissing-prototypes]
   int __weak arch_apei_enable_cmcff(struct acpi_hest_header *hest_hdr,
              ^
   drivers/acpi/apei/apei-base.c:804:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int __weak arch_apei_enable_cmcff(struct acpi_hest_header *hest_hdr,
   ^
   static 
   drivers/acpi/apei/apei-base.c:811:13: warning: no previous prototype for function 'arch_apei_report_mem_error' [-Wmissing-prototypes]
   void __weak arch_apei_report_mem_error(int sev,
               ^
   drivers/acpi/apei/apei-base.c:811:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void __weak arch_apei_report_mem_error(int sev,
   ^
   static 
   3 warnings generated.


vim +/remove_quirk_mcfg_res +453 drivers/acpi/apei/apei-base.c

   451	
   452	#ifdef CONFIG_PCI
 > 453	int remove_quirk_mcfg_res(struct apei_resources *mcfg_res)
   454	{
   455	#ifdef CONFIG_PCI_QUIRKS
   456		int rc = 0;
   457		struct apei_resources quirk_res;
   458	
   459		apei_resources_init(&quirk_res);
   460		rc = apei_res_add(&quirk_res.iomem, pci_quirk_mcfg_res.start,
   461			resource_size(&pci_quirk_mcfg_res));
   462		if (rc)
   463			return rc;
   464	
   465		return apei_resources_sub(mcfg_res, &quirk_res);
   466	#else
   467		return 0;
   468	#endif
   469	}
   470	extern struct list_head pci_mmcfg_list;
   471	static int apei_filter_mcfg_addr(struct apei_resources *res,
   472				struct apei_resources *mcfg_res)
   473	{
   474		int rc = 0;
   475		struct pci_mmcfg_region *cfg;
   476	
   477		if (list_empty(&pci_mmcfg_list))
   478			return 0;
   479	
   480		apei_resources_init(mcfg_res);
   481		list_for_each_entry(cfg, &pci_mmcfg_list, list) {
   482			rc = apei_res_add(&mcfg_res->iomem, cfg->res.start,
   483					resource_size(&cfg->res));
   484			if (rc)
   485				return rc;
   486		}
   487	
   488		/* remove the pci quirk mcfg resource if any from the mcfg_res */
   489		rc = remove_quirk_mcfg_res(mcfg_res);
   490		if (rc)
   491			return rc;
   492	
   493		/* filter the mcfg resource from current APEI's */
   494		return apei_resources_sub(res, mcfg_res);
   495	}
   496	#else
   497	static inline int apei_filter_mcfg_addr(struct apei_resources *res,
   498				struct apei_resources *mcfg_res)
   499	{
   500		return 0;
   501	}
   502	#endif
   503	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37965 bytes --]