Re: [PATCH 5/6] KVM: x86/xen: Maintain valid mapping of Xen shared_inf=

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3415 bytes --]

Hi David,

I love your patch! Yet something to improve:

[auto build test ERROR on kvm/queue]
[also build test ERROR on mst-vhost/linux-next v5.15 next-20211101]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/David-Woodhouse/KVM-x86-xen-Maintain-valid-mapping-of-Xen-shared_inf/20211101-161824
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue
config: x86_64-randconfig-a003-20211101 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 82ed106567063ea269c6d5669278b733e173a42f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/5faac25097318b72a65ed637b6a46ec92353cadb
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review David-Woodhouse/KVM-x86-xen-Maintain-valid-mapping-of-Xen-shared_inf/20211101-161824
        git checkout 5faac25097318b72a65ed637b6a46ec92353cadb
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> arch/x86/kvm/xen.c:36:17: error: incompatible pointer types passing 'struct kvm *' to parameter of type 'struct kvm_vcpu *' [-Werror,-Wincompatible-pointer-types]
                   kvm_unmap_gfn(kvm, &kvm->arch.xen.shinfo_map,
                                 ^~~
   include/linux/kvm_host.h:923:36: note: passing argument to parameter 'vcpu' here
   int kvm_unmap_gfn(struct kvm_vcpu *vcpu, struct kvm_host_map *map,
                                      ^
   arch/x86/kvm/xen.c:64:20: error: incompatible pointer types passing 'struct kvm *' to parameter of type 'struct kvm_vcpu *' [-Werror,-Wincompatible-pointer-types]
           ret = kvm_map_gfn(kvm, gfn, &kvm->arch.xen.shinfo_map,
                             ^~~
   include/linux/kvm_host.h:919:34: note: passing argument to parameter 'vcpu' here
   int kvm_map_gfn(struct kvm_vcpu *vcpu, gfn_t gfn, struct kvm_host_map *map,
                                    ^
   2 errors generated.


vim +36 arch/x86/kvm/xen.c

    23	
    24	static void kvm_xen_shared_info_unmap(struct kvm *kvm)
    25	{
    26		bool was_valid = false;
    27	
    28		write_lock(&kvm->arch.xen.shinfo_lock);
    29		if (kvm->arch.xen.shared_info)
    30			was_valid = true;
    31		kvm->arch.xen.shared_info = NULL;
    32		kvm->arch.xen.shinfo_gfn = GPA_INVALID;
    33		write_unlock(&kvm->arch.xen.shinfo_lock);
    34	
    35		if (kvm_vcpu_mapped(&kvm->arch.xen.shinfo_map)) {
  > 36			kvm_unmap_gfn(kvm, &kvm->arch.xen.shinfo_map,
    37				      &kvm->arch.xen.shinfo_cache, was_valid, false);
    38	
    39			/* If the MMU notifier invalidated it, the gfn_to_pfn_cache
    40			 * may be invalid. Force it to notice */
    41			if (!was_valid)
    42				kvm->arch.xen.shinfo_cache.generation = -1;
    43		}
    44	}
    45	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31258 bytes --]