From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25AB02C85 for ; Fri, 5 Nov 2021 13:26:17 +0000 (UTC) Received: by mail-oi1-f170.google.com with SMTP id bn12so14559047oib.2 for ; Fri, 05 Nov 2021 06:26:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=SS/+GawiHt4AKQM+4dzNVtQd4ve18Yf7ZbG8yygMuQ8=; b=EIpAESqujtMyfMEh64OQ3A4jvZTIkxWetvJm4blYAyALH/1z9KT46AM0yJbk3EpYf4 Z1hxc8w98ugDN+dX8C5NTkAc7i7YlYpCgIMorJMMltqIcObvxOthb0THrAzMNhIrmbha n5SnTqCKxjW6CjtcXV1dhOcGZc/YJDgvYM72VSRAzO9EPa4p64MDH8yagR8xy4apfNr6 VhUryQ5bcLzqEcLWEosrQnxmjl2FfJiR3ZN0KRl7mLo+tOrWWmuBaD90EFKWjN1voqHA AaNzXqahv+3Wt8qoIK8bqdvDcKSZJqgMYk+EgLdpiFJ9NuxklutHxotoL4d5LUHYK+Q2 CZdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mime-version:content-disposition; bh=SS/+GawiHt4AKQM+4dzNVtQd4ve18Yf7ZbG8yygMuQ8=; b=blqrnkjFpJ4QQ0jh5UZLQ8PWia7C9f4Y4kXqb8opM04ATgst2LUMqMrsunTiZQRrvM BrOUd1WsdRXs1Jasv60Q59wwBNqCT1Va0PSoTYyj33j2CNG1rsBwA0xGA2dlcBnJzlHA Ldh1YWtmvGoQb4cQkZ2EwZl5JxUQ5ims068AwmdpNJ3H+layGApEO86wfD37oCEMAyTZ kvT7DUd8VUTdBsB0bUHjO11ipJip3NsxzU/QpZkE5JUvrY+yn3xdiB52/etryTBGUChP Z5/iUs8at39SgKLj7WEXi/Vbnn1FhW/naaanvE9DXgqUmO2bz4FLHbmcOQVyGZFmTzLM Gkpw== X-Gm-Message-State: AOAM531nQ+TA8XI9aPARilGb9kaCc2tanzKGbxHKCHZbkzQWiF0d185J KfniMRKcyqvtma9WqMpgz4M= X-Google-Smtp-Source: ABdhPJzQxYMD6ED3vyItTfr3+KH21wd2coF0sEr2XvgMNrjO1G5P6FF5lP/RNtLGITHR9T0jJ7B2EA== X-Received: by 2002:a05:6808:1483:: with SMTP id e3mr12400151oiw.83.1636118776298; Fri, 05 Nov 2021 06:26:16 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id m21sm2250944otp.75.2021.11.05.06.26.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Nov 2021 06:26:15 -0700 (PDT) Sender: Guenter Roeck Date: Fri, 5 Nov 2021 06:26:14 -0700 From: Guenter Roeck To: Herbert Xu Cc: Ido Schimmel , Geert Uytterhoeven , Damien Le Moal , Nathan Chancellor , Linux Crypto Mailing List , Vladis Dronov , Simo Sorce , Eric Biggers , "llvm@lists.linux.dev" , kernel test robot , "linux-kernel@vger.kernel.org" Subject: Re: crypto: api - Fix boot-up crash when crypto manager is disabled Message-ID: <20211105132614.GA2791625@roeck-us.net> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 05, 2021 at 03:26:08PM +0800, Herbert Xu wrote: > On Thu, Nov 04, 2021 at 05:18:34PM +0200, Ido Schimmel wrote: > > > > Attached my config. I can easily test patches. > > Thanks! > > Could you all try this patch please? > > ---8<--- > When the crypto manager is disabled, we need to explicitly set > the crypto algorithms' tested status so that they can be used. > > Fixes: cad439fc040e ("crypto: api - Do not create test larvals if...") > Reported-by: Geert Uytterhoeven > Reported-by: Ido Schimmel > Reported-by: Guenter Roeck > Signed-off-by: Herbert Xu Tested-by: Guenter Roeck > > diff --git a/crypto/algapi.c b/crypto/algapi.c > index d379fd91fb7b..a366cb3e8aa1 100644 > --- a/crypto/algapi.c > +++ b/crypto/algapi.c > @@ -284,6 +284,8 @@ static struct crypto_larval *__crypto_register_alg(struct crypto_alg *alg) > > if (larval) > list_add(&larval->alg.cra_list, &crypto_alg_list); > + else > + alg->cra_flags |= CRYPTO_ALG_TESTED; > > crypto_stats_init(alg); > > -- > Email: Herbert Xu > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt