Re: [PATCH 3/3] ucounts: Move get_ucounts from cred_alloc_blank to key_change_session_keyring

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4576 bytes --]

Hi "Eric,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linux/master]
[cannot apply to linus/master jmorris-security/next-testing v5.15 next-20211106]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Eric-W-Biederman/ucounts-Pair-inc_rlimit_ucounts-with-dec_rlimit_ucoutns-in-commit_creds/20211019-022345
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git ec681c53f8d2d0ee362ff67f5b98dd8263c15002
config: i386-buildonly-randconfig-r003-20211021 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 3cea2505fd8d99a9ba0cb625aecfe28a47c4e3f8)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/78e52b4abddecd7a6666f768874ee737c292830d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Eric-W-Biederman/ucounts-Pair-inc_rlimit_ucounts-with-dec_rlimit_ucoutns-in-commit_creds/20211019-022345
        git checkout 78e52b4abddecd7a6666f768874ee737c292830d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> security/keys/process_keys.c:923:21: error: more '%' conversions than data arguments [-Werror,-Wformat-insufficient-args]
                   WARN_ONCE(1, "In %s get_ucounts failed\n");
                                    ~^
   include/asm-generic/bug.h:150:38: note: expanded from macro 'WARN_ONCE'
           DO_ONCE_LITE_IF(condition, WARN, 1, format)
                                               ^~~~~~
   include/linux/once_lite.h:19:9: note: expanded from macro 'DO_ONCE_LITE_IF'
                           func(__VA_ARGS__);                              \
                                ^~~~~~~~~~~
   include/asm-generic/bug.h:132:29: note: expanded from macro 'WARN'
                   __WARN_printf(TAINT_WARN, format);                      \
                                             ^~~~~~
   include/asm-generic/bug.h:99:17: note: expanded from macro '__WARN_printf'
                   __warn_printk(arg);                                     \
                                 ^~~
   1 error generated.


vim +923 security/keys/process_keys.c

   906	
   907	/*
   908	 * Replace a process's session keyring on behalf of one of its children when
   909	 * the target  process is about to resume userspace execution.
   910	 */
   911	void key_change_session_keyring(struct callback_head *twork)
   912	{
   913		const struct cred *old = current_cred();
   914		struct cred *new = container_of(twork, struct cred, rcu);
   915	
   916		if (unlikely(current->flags & PF_EXITING)) {
   917			put_cred(new);
   918			return;
   919		}
   920	
   921		/* If get_ucounts fails more bits are needed in the refcount */
   922		if (unlikely(!get_ucounts(old->ucounts))) {
 > 923			WARN_ONCE(1, "In %s get_ucounts failed\n");
   924			put_cred(new);
   925			return;
   926		}
   927	
   928		new->  uid	= old->  uid;
   929		new-> euid	= old-> euid;
   930		new-> suid	= old-> suid;
   931		new->fsuid	= old->fsuid;
   932		new->  gid	= old->  gid;
   933		new-> egid	= old-> egid;
   934		new-> sgid	= old-> sgid;
   935		new->fsgid	= old->fsgid;
   936		new->user	= get_uid(old->user);
   937		new->ucounts	= old->ucounts;
   938		new->user_ns	= get_user_ns(old->user_ns);
   939		new->group_info	= get_group_info(old->group_info);
   940	
   941		new->securebits	= old->securebits;
   942		new->cap_inheritable	= old->cap_inheritable;
   943		new->cap_permitted	= old->cap_permitted;
   944		new->cap_effective	= old->cap_effective;
   945		new->cap_ambient	= old->cap_ambient;
   946		new->cap_bset		= old->cap_bset;
   947	
   948		new->jit_keyring	= old->jit_keyring;
   949		new->thread_keyring	= key_get(old->thread_keyring);
   950		new->process_keyring	= key_get(old->process_keyring);
   951	
   952		security_transfer_creds(new, old);
   953	
   954		commit_creds(new);
   955	}
   956	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36838 bytes --]