* Re: [RFC PATCH v4 1/8] leds: add support for hardware driven LEDs
[not found] <20211111013500.13882-2-ansuelsmth@gmail.com>
@ 2021-11-11 8:48 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-11-11 8:48 UTC (permalink / raw)
To: Ansuel Smith; +Cc: llvm, kbuild-all
[-- Attachment #1: Type: text/plain, Size: 5514 bytes --]
Hi Ansuel,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on net/master]
[also build test ERROR on linus/master next-20211111]
[cannot apply to pavel-leds/for-next robh/for-next net-next/master v5.15]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Ansuel-Smith/Adds-support-for-PHY-LEDs-with-offload-triggers/20211111-093724
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git e5d5aadcf3cd59949316df49c27cb21788d7efe4
config: riscv-buildonly-randconfig-r002-20211111 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 63ef0e17e28827eae53133b3467bdac7d9729318)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/0day-ci/linux/commit/c56c3d000ada0de02ec9ecf03e93327733b91930
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Ansuel-Smith/Adds-support-for-PHY-LEDs-with-offload-triggers/20211111-093724
git checkout c56c3d000ada0de02ec9ecf03e93327733b91930
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash arch/riscv/kernel/ drivers/gpu/drm/ drivers/leds/ net/core/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/leds/led-triggers.c:198:17: error: no member named 'hw_control_status' in 'struct led_classdev'
led_cdev->hw_control_status(led_cdev))
~~~~~~~~ ^
>> drivers/leds/led-triggers.c:199:14: error: no member named 'hw_control_stop' in 'struct led_classdev'
led_cdev->hw_control_stop(led_cdev);
~~~~~~~~ ^
2 errors generated.
vim +198 drivers/leds/led-triggers.c
170
171 /* Caller must ensure led_cdev->trigger_lock held */
172 int led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig)
173 {
174 char *event = NULL;
175 char *envp[2];
176 const char *name;
177 int ret;
178
179 if (!led_cdev->trigger && !trig)
180 return 0;
181
182 name = trig ? trig->name : "none";
183 event = kasprintf(GFP_KERNEL, "TRIGGER=%s", name);
184
185 /* Remove any existing trigger */
186 if (led_cdev->trigger) {
187 spin_lock(&led_cdev->trigger->leddev_list_lock);
188 list_del_rcu(&led_cdev->trig_list);
189 spin_unlock(&led_cdev->trigger->leddev_list_lock);
190
191 /* ensure it's no longer visible on the led_cdevs list */
192 synchronize_rcu();
193
194 cancel_work_sync(&led_cdev->set_brightness_work);
195 led_stop_software_blink(led_cdev);
196 /* Disable hardware mode on trigger change if supported */
197 if ((led_cdev->flags & LED_HARDWARE_CONTROLLED) &&
> 198 led_cdev->hw_control_status(led_cdev))
> 199 led_cdev->hw_control_stop(led_cdev);
200 if (led_cdev->trigger->deactivate)
201 led_cdev->trigger->deactivate(led_cdev);
202 device_remove_groups(led_cdev->dev, led_cdev->trigger->groups);
203 led_cdev->trigger = NULL;
204 led_cdev->trigger_data = NULL;
205 led_cdev->activated = false;
206 led_set_brightness(led_cdev, LED_OFF);
207 }
208 if (trig) {
209 /* Make sure the trigger support the LED blink mode */
210 if (!led_trigger_is_supported(led_cdev, trig))
211 return -EINVAL;
212
213 spin_lock(&trig->leddev_list_lock);
214 list_add_tail_rcu(&led_cdev->trig_list, &trig->led_cdevs);
215 spin_unlock(&trig->leddev_list_lock);
216 led_cdev->trigger = trig;
217
218 if (trig->activate)
219 ret = trig->activate(led_cdev);
220 else
221 ret = 0;
222
223 if (ret)
224 goto err_activate;
225
226 ret = device_add_groups(led_cdev->dev, trig->groups);
227 if (ret) {
228 dev_err(led_cdev->dev, "Failed to add trigger attributes\n");
229 goto err_add_groups;
230 }
231 }
232
233 if (event) {
234 envp[0] = event;
235 envp[1] = NULL;
236 if (kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp))
237 dev_err(led_cdev->dev,
238 "%s: Error sending uevent\n", __func__);
239 kfree(event);
240 }
241
242 return 0;
243
244 err_add_groups:
245
246 if (trig->deactivate)
247 trig->deactivate(led_cdev);
248 err_activate:
249
250 spin_lock(&led_cdev->trigger->leddev_list_lock);
251 list_del_rcu(&led_cdev->trig_list);
252 spin_unlock(&led_cdev->trigger->leddev_list_lock);
253 synchronize_rcu();
254 led_cdev->trigger = NULL;
255 led_cdev->trigger_data = NULL;
256 led_set_brightness(led_cdev, LED_OFF);
257 kfree(event);
258
259 return ret;
260 }
261 EXPORT_SYMBOL_GPL(led_trigger_set);
262
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32816 bytes --]
^ permalink raw reply [flat|nested] only message in thread