From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 439CE2C80 for ; Tue, 7 Dec 2021 11:01:03 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id w1so55327581edc.6 for ; Tue, 07 Dec 2021 03:01:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ptsvV1kleA1LtJa+QFl6NmI3SOUoq7RBkJ0eF/rWVyU=; b=AkuoJj6cCFFXgQqRtrrmz1i66mQV9j6h2awDmburQUuGzBr86ub6W2c4ZcdtbT324j DvrThKp2QleDKBIrI25cGkr9BJZGNlDmH/TeC/KkrmrhzFW3l6T5oSovmvGsI+GVULlx dyMuU3ZwI2Ct1Bf5lqpZqbOfWZY41FfZA/ygU+egJjQT2C+CBQnKxYhu72bm4Bmi3Vgn f4aLfvyIsDhlN7gfSHNv70b1g+CleSswJAb2YHgHp11D9Ml987EItr6T2T/70yCpRCRi Icij1+d6W+EIDT2n0CAcGCUtrdDs/RxozhUhiKV17RI6+7VKAyiK2BKAGAdUNzYfEVXc +nZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ptsvV1kleA1LtJa+QFl6NmI3SOUoq7RBkJ0eF/rWVyU=; b=cXJyOdvFsBk3i/ErEKhiPhAW+NF56QPOYmSrGjrIXRVy01ho5lK39tLxQS9w8UsCnG 1zE+/8jjCOWuda2NQ8orZPyjX4ARxrsoIgSNUuxDT8U6qq7KTGVp2hF0XTxCUkDCigOg MFeGbe2Pz2kDFW3vz+XRSD2HextGB51nhwN/G1rfJC6ZQaEJXKyiGT0qaXbEY3UBCAql ioO13DDj/87C0vWdxJodVWpA/9qCzKguj67Q4prhnj2am+wu7i/JilDcz+KZEm0yzT+c 4tiM4eYJhXZa5293nsZSbUBmMHCG8ipQUajORD/46+XOfuGJyuPcCixn3shBGzP/RFE2 D44w== X-Gm-Message-State: AOAM531NuAatYHT/6i1gFElbCSIFoW1NeZI53vfojT20T9aS845yEp1k 6lXvVJ7Dh0Xa2v5ImZOdHq1CCw== X-Google-Smtp-Source: ABdhPJyL8WuOA2aVcFyjxLd0b5iozXAcekRxzldlcNfDg1/+YC8Ucg0r3084WvyJl0shdFPPBaIbRg== X-Received: by 2002:a05:6402:147:: with SMTP id s7mr7987920edu.8.1638874861500; Tue, 07 Dec 2021 03:01:01 -0800 (PST) Received: from localhost (c-9b28e555.07-21-73746f28.bbcust.telenor.se. [85.229.40.155]) by smtp.gmail.com with ESMTPSA id h10sm9939533edr.95.2021.12.07.03.01.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Dec 2021 03:01:01 -0800 (PST) From: Anders Roxell To: perex@perex.cz, tiwai@suse.com Cc: nathan@kernel.org, ndesaulniers@google.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Anders Roxell , Naresh Kamboju Subject: [PATCH] sound: ppc: beep: fix clang -Wimplicit-fallthrough Date: Tue, 7 Dec 2021 12:00:53 +0100 Message-Id: <20211207110053.695712-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.33.0 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Clang warns: sound/ppc/beep.c:103:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] case SND_TONE: break; ^ sound/ppc/beep.c:103:2: note: insert 'break;' to avoid fall-through case SND_TONE: break; ^ break; 1 warning generated. Clang is more pedantic than GCC, which does not warn when failing through to a case that is just break or return. Clang's version is more in line with the kernel's own stance in deprecated.rst. Add athe missing break to silence the warning. Reported-by: Naresh Kamboju Signed-off-by: Anders Roxell --- sound/ppc/beep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/ppc/beep.c b/sound/ppc/beep.c index 0f4bce1c0d4f..bf289783eafd 100644 --- a/sound/ppc/beep.c +++ b/sound/ppc/beep.c @@ -99,7 +99,7 @@ static int snd_pmac_beep_event(struct input_dev *dev, unsigned int type, return -1; switch (code) { - case SND_BELL: if (hz) hz = 1000; + case SND_BELL: if (hz) hz = 1000; break; case SND_TONE: break; default: return -1; } -- 2.33.0