Re: [PATCH V3 4/6] platform/x86: Add Intel Software Defined Silicon driver

kernel test robot
2021-12-15T06:39:52Z

Hi "David,

I love your patch! Yet something to improve:

[auto build test ERROR on lee-mfd/for-mfd-next]
[also build test ERROR on helgaas-pci/next shuah-kselftest/next linus/master v5.16-rc5 next-20211214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/David-E-Box/Auxiliary-bus-driver-support-for-Intel-PCIe-VSEC-DVSEC/20211214-020016
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: x86_64-randconfig-r013-20211214 (https://download.01.org/0day-ci/archive/20211215/202112151420.ZVi8YXOl-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a2ddb6c8ac29412b1361810972e15221fa021c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/405984bb2427331f6e97ffef42244a5d2d090da3
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review David-E-Box/Auxiliary-bus-driver-support-for-Intel-PCIe-VSEC-DVSEC/20211214-020016
git checkout 405984bb2427331f6e97ffef42244a5d2d090da3
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/platform/x86/intel/sdsi.c:566:2: error: expected ';' after top level declarator
}
^
;
1 error generated.

vim +566 drivers/platform/x86/intel/sdsi.c

558
559 static struct auxiliary_driver sdsi_aux_driver = {
560 .driver = {
561 .dev_groups = sdsi_groups,
562 },
563 .id_table = sdsi_aux_id_table,
564 .probe = sdsi_probe,
565 /* No remove. All resources are handled under devm */
> 566 }
567 module_auxiliary_driver(sdsi_aux_driver);
568

---
0-DAY CI Kernel Test Service, Intel Corporation