Re: [PATCH net-next v3 06/11] net: dsa: realtek: add new mdio interface for drivers

Re: [PATCH net-next v3 06/11] net: dsa: realtek: add new mdio interface for drivers

[kernel test robot]

Hi Luiz,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Luiz-Angelo-Daros-de-Luca/net-dsa-realtek-smi-move-to-subdirectory/20211231-133326
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git af30f8eaa8fe4ff1987280f716309711997bd979
config: hexagon-randconfig-r033-20211231 (https://download.01.org/0day-ci/archive/20220101/202201010143.Ua57feb3-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 7cd109b92c72855937273a6c8ab19016fbe27d33)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/98bde88720c76b12ab9ed2cfc166f65396e6e5e2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Luiz-Angelo-Daros-de-Luca/net-dsa-realtek-smi-move-to-subdirectory/20211231-133326
        git checkout 98bde88720c76b12ab9ed2cfc166f65396e6e5e2
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/net/dsa/realtek/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/dsa/realtek/realtek-mdio.c:41:5: warning: no previous prototype for function 'realtek_mdio_read_reg' [-Wmissing-prototypes]
   int realtek_mdio_read_reg(struct realtek_priv *priv, u32 addr, u32 *data)
       ^
   drivers/net/dsa/realtek/realtek-mdio.c:41:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int realtek_mdio_read_reg(struct realtek_priv *priv, u32 addr, u32 *data)
   ^
   static 
   1 warning generated.


vim +/realtek_mdio_read_reg +41 drivers/net/dsa/realtek/realtek-mdio.c

    40	
  > 41	int realtek_mdio_read_reg(struct realtek_priv *priv, u32 addr, u32 *data)
    42	{
    43		u32 phy_id = priv->phy_id;
    44		struct mii_bus *bus = priv->bus;
    45	
    46		mutex_lock(&bus->mdio_lock);
    47	
    48		bus->write(bus, phy_id, REALTEK_MDIO_CTRL0_REG, REALTEK_MDIO_ADDR_OP);
    49		bus->write(bus, phy_id, REALTEK_MDIO_START_REG, REALTEK_MDIO_START_OP);
    50		bus->write(bus, phy_id, REALTEK_MDIO_ADDRESS_REG, addr);
    51		bus->write(bus, phy_id, REALTEK_MDIO_START_REG, REALTEK_MDIO_START_OP);
    52		bus->write(bus, phy_id, REALTEK_MDIO_CTRL1_REG, REALTEK_MDIO_READ_OP);
    53		bus->write(bus, phy_id, REALTEK_MDIO_START_REG, REALTEK_MDIO_START_OP);
    54		*data = bus->read(bus, phy_id, REALTEK_MDIO_DATA_READ_REG);
    55	
    56		mutex_unlock(&bus->mdio_lock);
    57	
    58		return 0;
    59	}
    60	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org