Re: [PATCH v2 07/35] brcmfmac: pcie: Read Apple OTP information

Re: [PATCH v2 07/35] brcmfmac: pcie: Read Apple OTP information

[kernel test robot]

Hi Hector,

I love your patch! Perhaps something to improve:

[auto build test WARNING on kvalo-wireless-drivers-next/master]
[also build test WARNING on kvalo-wireless-drivers/master rafael-pm/linux-next net-next/master net/master robh/for-next linus/master v5.16-rc8 next-20220105]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Hector-Martin/brcmfmac-Support-Apple-T2-and-M1-platforms/20220104-153413
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: x86_64-randconfig-r024-20220105 (https://download.01.org/0day-ci/archive/20220106/202201060758.hCG39IaN-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d5b6e30ed3acad794dd0aec400e617daffc6cc3d)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/e81f1e021ca0e590a603102125ba1ad03dfff42c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Hector-Martin/brcmfmac-Support-Apple-T2-and-M1-platforms/20220104-153413
        git checkout e81f1e021ca0e590a603102125ba1ad03dfff42c
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/wireless/broadcom/brcm80211/brcmfmac/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c:1863:20: warning: address of array 'devinfo->otp.version' will always evaluate to 'true' [-Wpointer-bool-conversion]
               !devinfo->otp.version)
               ~~~~~~~~~~~~~~^~~~~~~
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c:1862:20: warning: address of array 'devinfo->otp.vendor' will always evaluate to 'true' [-Wpointer-bool-conversion]
               !devinfo->otp.vendor ||
               ~~~~~~~~~~~~~~^~~~~~
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c:1861:20: warning: address of array 'devinfo->otp.module' will always evaluate to 'true' [-Wpointer-bool-conversion]
           if (!devinfo->otp.module ||
               ~~~~~~~~~~~~~~^~~~~~
   3 warnings generated.


vim +1863 drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c

  1785	
  1786	static int
  1787	brcmf_pcie_parse_otp_sys_vendor(struct brcmf_pciedev_info *devinfo,
  1788					u8 *data, size_t size)
  1789	{
  1790		int idx = 4;
  1791		const char *chip_params;
  1792		const char *board_params;
  1793		const char *p;
  1794	
  1795		/* 4-byte header and two empty strings */
  1796		if (size < 6)
  1797			return -EINVAL;
  1798	
  1799		if (get_unaligned_le32(data) != BRCMF_OTP_VENDOR_HDR)
  1800			return -EINVAL;
  1801	
  1802		chip_params = &data[idx];
  1803	
  1804		/* Skip first string, including terminator */
  1805		idx += strnlen(chip_params, size - idx) + 1;
  1806		if (idx >= size)
  1807			return -EINVAL;
  1808	
  1809		board_params = &data[idx];
  1810	
  1811		/* Skip to terminator of second string */
  1812		idx += strnlen(board_params, size - idx);
  1813		if (idx >= size)
  1814			return -EINVAL;
  1815	
  1816		/* At this point both strings are guaranteed NUL-terminated */
  1817		brcmf_dbg(PCIE, "OTP: chip_params='%s' board_params='%s'\n",
  1818			  chip_params, board_params);
  1819	
  1820		p = board_params;
  1821		while (*p) {
  1822			char tag = *p++;
  1823			const char *end;
  1824			size_t len;
  1825	
  1826			if (tag == ' ') /* Skip extra spaces */
  1827				continue;
  1828	
  1829			if (*p++ != '=') /* implicit NUL check */
  1830				return -EINVAL;
  1831	
  1832			/* *p might be NUL here, if so end == p and len == 0 */
  1833			end = strchrnul(p, ' ');
  1834			len = end - p;
  1835	
  1836			/* leave 1 byte for NUL in destination string */
  1837			if (len > (BRCMF_OTP_MAX_PARAM_LEN - 1))
  1838				return -EINVAL;
  1839	
  1840			/* Copy len characters plus a NUL terminator */
  1841			switch (tag) {
  1842			case 'M':
  1843				strscpy(devinfo->otp.module, p, len + 1);
  1844				break;
  1845			case 'V':
  1846				strscpy(devinfo->otp.vendor, p, len + 1);
  1847				break;
  1848			case 'm':
  1849				strscpy(devinfo->otp.version, p, len + 1);
  1850				break;
  1851			}
  1852	
  1853			/* Skip to space separator or NUL */
  1854			p = end;
  1855		}
  1856	
  1857		brcmf_dbg(PCIE, "OTP: module=%s vendor=%s version=%s\n",
  1858			  devinfo->otp.module, devinfo->otp.vendor,
  1859			  devinfo->otp.version);
  1860	
> 1861		if (!devinfo->otp.module ||
> 1862		    !devinfo->otp.vendor ||
> 1863		    !devinfo->otp.version)
  1864			return -EINVAL;
  1865	
  1866		devinfo->otp.valid = true;
  1867		return 0;
  1868	}
  1869	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org